You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Matt Foley (JIRA)" <ji...@apache.org> on 2011/03/11 19:15:59 UTC

[jira] Created: (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
---------------------------------------------------------------------------------------------

                 Key: HADOOP-7182
                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
             Project: Hadoop Common
          Issue Type: Improvement
          Components: util
    Affects Versions: 0.23.0
            Reporter: Matt Foley
            Assignee: Matt Foley
            Priority: Minor
             Fix For: 0.23.0


This is the third part of a refactoring of HardLink:
1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Foley updated HADOOP-7182:
-------------------------------

    Fix Version/s:     (was: 0.23.0)
         Assignee:     (was: Matt Foley)
           Status: Open  (was: Patch Available)

Suresh pointed out that this was formerly a public interface, so may be used in custom jobs.  Rather than force all such jobs to update with the release of v23, it seems better to leave this cleanup task for the indefinite future.

The API has been deprecated, and can be removed whenever the community feels it will not cause undue disruption to users.  In the meantime, the patch is withdrawn.

> remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Priority: Minor
>         Attachments: HADOOP-7182-cleanup.patch
>
>
> This is the third part of a refactoring of HardLink:
> 1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
> 2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
> 3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021277#comment-13021277 ] 

Suresh Srinivas commented on HADOOP-7182:
-----------------------------------------

Since FileUtil is marked Public, should we leave the deprecated class as it is and may be remove it in the next release?

> remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7182-cleanup.patch
>
>
> This is the third part of a refactoring of HardLink:
> 1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
> 2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
> 3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021295#comment-13021295 ] 

Jakob Homan commented on HADOOP-7182:
-------------------------------------

our policy has been to leave deprecated classes in for two releases and then remove them, to give the community time to move over to the new classes.  I usually mark it as @Deprecated // in XX to be removed in XX+2 so people can easily tell when they can safely delete the class.

> remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Priority: Minor
>         Attachments: HADOOP-7182-cleanup.patch
>
>
> This is the third part of a refactoring of HardLink:
> 1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
> 2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
> 3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Foley updated HADOOP-7182:
-------------------------------

    Status: Patch Available  (was: Open)

> remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7182-cleanup.patch
>
>
> This is the third part of a refactoring of HardLink:
> 1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
> 2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
> 3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HADOOP-7182) remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies

Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Foley updated HADOOP-7182:
-------------------------------

    Attachment: HADOOP-7182-cleanup.patch

Removes stub implementation per spec.

> remove stub implementation of HardLink from FileUtil, after fixing any remaining dependencies
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7182
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7182
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7182-cleanup.patch
>
>
> This is the third part of a refactoring of HardLink:
> 1. HADOOP-7133 moved HardLink from an inner class of FileUtil to a stand-alone class, but left a stub class in FileUtil to prevent breaking clients in HDFS.
> 2. HDFS-1445 changes the clients in HDFS to point at the new implementation.
> 3. After HDFS-1445 is committed, this ticket is to clean up the code by removing the backward-compatibility stub.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira