You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dave <sn...@gmail.com> on 2008/06/18 21:05:41 UTC
Extending DataRequestHandler.java?
I'd like plugin my own DataRequestHandlers, but the DataRequestHandler
class seems to be designed to prevent subclassing. Would you consider
changing or accepting a patch to make the protected and package
protected methods into public methods so the class can be extended?
- Dave
Re: Extending DataRequestHandler.java?
Posted by Dave <sn...@gmail.com>.
On Wed, Jun 18, 2008 at 3:47 PM, Cassie <do...@apache.org> wrote:
> Nah - that's package protected.
> So Dave, I just double checked, you can make all of the DataRequestHandlers
> protected instead of package protected and everything should work dandily
> for your sub class. protected will be better than public.
Yep, protected is better. Here's a patch:
https://issues.apache.org/jira/browse/SHINDIG-394
- Dave
Re: Extending DataRequestHandler.java?
Posted by Cassie <do...@apache.org>.
Nah - that's package protected.
So Dave, I just double checked, you can make all of the DataRequestHandlers
protected instead of package protected and everything should work dandily
for your sub class. protected will be better than public.
- Cassie
On Wed, Jun 18, 2008 at 12:39 PM, Ropu <ro...@gmail.com> wrote:
> if you are in the same package...
>
> On Wed, Jun 18, 2008 at 12:30 PM, Cassie <do...@apache.org> wrote:
>
> > Wait a sec. Can't you just make everything protected? Then your subclass
> > should work fine.
> >
> > - Cassie
> >
> > On Wed, Jun 18, 2008 at 12:28 PM, Cassie <do...@apache.org> wrote:
> >
> > > I guess that's fine although we might need an interface at some point
> > then
> > > so that it is clear what the actual contract of the DataRequestHandler
> > is.
> > >
> > > - Cassie
> > >
> > >
> > >
> > > On Wed, Jun 18, 2008 at 12:05 PM, Dave <sn...@gmail.com> wrote:
> > >
> > >> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler
> > >> class seems to be designed to prevent subclassing. Would you consider
> > >> changing or accepting a patch to make the protected and package
> > >> protected methods into public methods so the class can be extended?
> > >>
> > >> - Dave
> > >>
> > >
> > >
> >
>
>
>
> --
> .-. --- .--. ..-
> R o p u
>
Re: Extending DataRequestHandler.java?
Posted by Ropu <ro...@gmail.com>.
if you are in the same package...
On Wed, Jun 18, 2008 at 12:30 PM, Cassie <do...@apache.org> wrote:
> Wait a sec. Can't you just make everything protected? Then your subclass
> should work fine.
>
> - Cassie
>
> On Wed, Jun 18, 2008 at 12:28 PM, Cassie <do...@apache.org> wrote:
>
> > I guess that's fine although we might need an interface at some point
> then
> > so that it is clear what the actual contract of the DataRequestHandler
> is.
> >
> > - Cassie
> >
> >
> >
> > On Wed, Jun 18, 2008 at 12:05 PM, Dave <sn...@gmail.com> wrote:
> >
> >> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler
> >> class seems to be designed to prevent subclassing. Would you consider
> >> changing or accepting a patch to make the protected and package
> >> protected methods into public methods so the class can be extended?
> >>
> >> - Dave
> >>
> >
> >
>
--
.-. --- .--. ..-
R o p u
Re: Extending DataRequestHandler.java?
Posted by Cassie <do...@apache.org>.
Wait a sec. Can't you just make everything protected? Then your subclass
should work fine.
- Cassie
On Wed, Jun 18, 2008 at 12:28 PM, Cassie <do...@apache.org> wrote:
> I guess that's fine although we might need an interface at some point then
> so that it is clear what the actual contract of the DataRequestHandler is.
>
> - Cassie
>
>
>
> On Wed, Jun 18, 2008 at 12:05 PM, Dave <sn...@gmail.com> wrote:
>
>> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler
>> class seems to be designed to prevent subclassing. Would you consider
>> changing or accepting a patch to make the protected and package
>> protected methods into public methods so the class can be extended?
>>
>> - Dave
>>
>
>
Re: Extending DataRequestHandler.java?
Posted by Cassie <do...@apache.org>.
I guess that's fine although we might need an interface at some point then
so that it is clear what the actual contract of the DataRequestHandler is.
- Cassie
On Wed, Jun 18, 2008 at 12:05 PM, Dave <sn...@gmail.com> wrote:
> I'd like plugin my own DataRequestHandlers, but the DataRequestHandler
> class seems to be designed to prevent subclassing. Would you consider
> changing or accepting a patch to make the protected and package
> protected methods into public methods so the class can be extended?
>
> - Dave
>