You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <eh...@gmail.com> on 2006/11/30 10:51:08 UTC

Fwd: [Issue 2670] New - svn client crashes during commit

Lieven,

Didn't you fix a problem which strikingly looks like this one?

bye,

Erik.

---------- Forwarded message ----------
From: bochen@tigris.org <bo...@tigris.org>
Date: 30 Nov 2006 10:20:49 -0000
Subject: [Issue 2670] New - svn client crashes during commit
To: issues@subversion.tigris.org


http://subversion.tigris.org/issues/show_bug.cgi?id=2670
                Issue #|2670
                Summary|svn client crashes during commit
              Component|subversion
                Version|all
               Platform|PC
                    URL|
             OS/Version|FreeBSD
                 Status|NEW
      Status whiteboard|
               Keywords|
             Resolution|
             Issue type|PATCH
               Priority|P3
           Subcomponent|libsvn_client
            Assigned to|issues@subversion
            Reported by|bochen






------- Additional comments from bochen@tigris.org Thu Nov 30 02:20:49
-0800 2006 -------
svn client crashes when during commiting files from different directories.
This problem is connected with FreeBSD and chroot/jail.
If working directory is chrooted user cann't commit files from different
directories.

Here is a patch to this issue:
--- subversion-1.4.0/subversion/libsvn_client/commit.c  Thu Nov 30 11:05:36 2006
*************** svn_client_commit3(svn_commit_info_t **c
*** 1268,1273 ****
--- 1268,1283 ----
                                  base_dir, rel_targets,
                                  pool));

+       /*
+         FIX for FreeBSD+chroot.
+         When directory is chrooted or just it is root
+         directory svn client crashes when one wants to commit
+         files from different directories.
+       */
+       if (!*base_dir) {
+         base_dir = apr_pstrdup(pool, "/");
+       }
+
       for (i = 0; i < rel_targets->nelts; i++)
         {
           const char *parent_dir, *name;

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@subversion.tigris.org
For additional commands, e-mail: issues-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Fwd: [Issue 2670] New - svn client crashes during commit

Posted by lg...@mobsol.be.
Yes I did. Issue 2576, solved in r20276 and backport to 1.4.x in 21039. It
should be fixed in 1.4.0.

I guess the reporter used svn 1.4.0 already, so I'd be interested in seeing a
testscript for the issue.

Lieven


Quoting Erik Huelsmann <eh...@gmail.com>:

> Lieven,
>
> Didn't you fix a problem which strikingly looks like this one?
>
> bye,
>
> Erik.
>
> ---------- Forwarded message ----------
> From: bochen@tigris.org <bo...@tigris.org>
> Date: 30 Nov 2006 10:20:49 -0000
> Subject: [Issue 2670] New - svn client crashes during commit
> To: issues@subversion.tigris.org
>
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=2670
>                 Issue #|2670

> Here is a patch to this issue:
> --- subversion-1.4.0/subversion/libsvn_client/commit.c  Thu Nov 30 11:05:36
> 2006
> *************** svn_client_commit3(svn_commit_info_t **c
> *** 1268,1273 ****
> --- 1268,1283 ----
>                                   base_dir, rel_targets,
>                                   pool));
>
> +       /*
> +         FIX for FreeBSD+chroot.
> +         When directory is chrooted or just it is root
> +         directory svn client crashes when one wants to commit
> +         files from different directories.
> +       */
> +       if (!*base_dir) {
> +         base_dir = apr_pstrdup(pool, "/");
> +       }
> +
>        for (i = 0; i < rel_targets->nelts; i++)
>          {
>            const char *parent_dir, *name;



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org