You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spamassassin.apache.org by Daniel Quinlan <qu...@pathname.com> on 2005/08/14 01:12:07 UTC

Re: svn commit: r230837 - /spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm

jm@apache.org writes:

> revert back to what the documented API says; caller code can easily
> set to 0 if they want to avoid the performance hit, and that's what
> should be done, instead of messing with public APIs.  be clearer in
> the doco though.

The date extraction should *only* be done if it is requested.
Otherwise, it is completely pointless.  Changing this is harmless and
correct.

Also, you do realize mass-check doesn't set this.  Only the -n (opt_n in
ArchiveIterator) flag in mass-check was rendered useless by your changes
to the ArchiveIterator.

Essentially, you added a new flag, opt_want_date, that changed the
behavior of opt_n.  Who is messing with public APIs, again?  ;-)

Daniel

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/