You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/02/06 00:25:59 UTC

[jira] Created: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

zk jmx code is calling printStackTrace when creating bean name (should not be)
------------------------------------------------------------------------------

                 Key: ZOOKEEPER-300
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
             Project: Zookeeper
          Issue Type: Bug
    Affects Versions: 3.1.0
            Reporter: Patrick Hunt
             Fix For: 3.2.0


remove printStackTrace from zk jmx code (review the rest of the code at the same time)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670960#action_12670960 ] 

Patrick Hunt commented on ZOOKEEPER-300:
----------------------------------------

in the case of malformedobjectnameexception we should also catch/rethrow this exception at a low enough level such that we can log (WARN) the name that was invalid (sun doesn't include that in the error message and it would be useful)

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>             Fix For: 3.2.0
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-300:
-----------------------------------

    Status: Patch Available  (was: Open)

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-300.patch
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-300:
--------------------------------------

    Assignee: Patrick Hunt

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-300:
-----------------------------------

    Component/s: jmx

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>             Fix For: 3.2.0
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-300:
-----------------------------------

    Attachment: ZOOKEEPER-300.patch

Replaced printStackTrace with proper logging and exception handling. Some of this (jmx esp) was fixed in an earlier patch, this is final cleanup.

Note: I've created a bookeeper issue related to tis' use of pst in main line code : ZOOKEEPER-391

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-300.patch
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-300:
------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. thanks pat.

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-300.patch
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-300) zk jmx code is calling printStackTrace when creating bean name (should not be)

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707166#action_12707166 ] 

Mahadev konar commented on ZOOKEEPER-300:
-----------------------------------------

+1 the patch looks good.

> zk jmx code is calling printStackTrace when creating bean name (should not be)
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-300
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: jmx
>    Affects Versions: 3.1.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-300.patch
>
>
> remove printStackTrace from zk jmx code (review the rest of the code at the same time)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.