You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/12 08:05:50 UTC
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #16504: [improve][broker][PIP-149]make getBacklogQuotaMap method async in Namespaces
gaoran10 commented on code in PR #16504:
URL: https://github.com/apache/pulsar/pull/16504#discussion_r918671930
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -1037,13 +1037,21 @@ public DispatchRate getReplicatorDispatchRate(@PathParam("tenant") String tenant
@ApiOperation(value = "Get backlog quota map on a namespace.")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist") })
- public Map<BacklogQuotaType, BacklogQuota> getBacklogQuotaMap(@PathParam("tenant") String tenant,
+ public void getBacklogQuotaMap(
+ @Suspended final AsyncResponse asyncResponse,
+ @PathParam("tenant") String tenant,
@PathParam("namespace") String namespace) {
validateNamespaceName(tenant, namespace);
- validateNamespacePolicyOperation(
- NamespaceName.get(tenant, namespace), PolicyName.BACKLOG, PolicyOperation.READ);
- Policies policies = getNamespacePolicies(namespaceName);
- return policies.backlog_quota_map;
+ validateNamespacePolicyOperationAsync(NamespaceName.get(tenant, namespace), PolicyName.BACKLOG,
Review Comment:
Could we use the param `namespaceName` to instead of
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -1037,13 +1037,21 @@ public DispatchRate getReplicatorDispatchRate(@PathParam("tenant") String tenant
@ApiOperation(value = "Get backlog quota map on a namespace.")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist") })
- public Map<BacklogQuotaType, BacklogQuota> getBacklogQuotaMap(@PathParam("tenant") String tenant,
+ public void getBacklogQuotaMap(
+ @Suspended final AsyncResponse asyncResponse,
+ @PathParam("tenant") String tenant,
@PathParam("namespace") String namespace) {
validateNamespaceName(tenant, namespace);
- validateNamespacePolicyOperation(
- NamespaceName.get(tenant, namespace), PolicyName.BACKLOG, PolicyOperation.READ);
- Policies policies = getNamespacePolicies(namespaceName);
- return policies.backlog_quota_map;
+ validateNamespacePolicyOperationAsync(NamespaceName.get(tenant, namespace), PolicyName.BACKLOG,
Review Comment:
Could we use the param `namespaceName` to instead of `NamespaceName.get(tenant, namespace)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org