You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "jgallimore (via GitHub)" <gi...@apache.org> on 2024/05/23 09:54:57 UTC
[PR] TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE w… (tomee)
jgallimore opened a new pull request, #1165:
URL: https://github.com/apache/tomee/pull/1165
…hen the cxf-rs service is initialized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE w… (tomee)
Posted by "jgallimore (via GitHub)" <gi...@apache.org>.
jgallimore commented on PR #1165:
URL: https://github.com/apache/tomee/pull/1165#issuecomment-2126710887
Further detail on the CXF list is here: https://lists.apache.org/thread/coxrst45zm8gqmf1hhx5g7bqzbsldkhh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4358 - Load SpringWebUtils in the context class loader in TomEE w… (tomee)
Posted by "jgallimore (via GitHub)" <gi...@apache.org>.
jgallimore closed pull request #1165: TOMEE-4358 - Load SpringWebUtils in the context class loader in TomEE w…
URL: https://github.com/apache/tomee/pull/1165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE w… (tomee)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #1165:
URL: https://github.com/apache/tomee/pull/1165#discussion_r1611564278
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/GreetingController.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.openejb.arquillian.tests.jaxrs.spring;
Review Comment:
Missing header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/DemoApplication.java:
##########
@@ -0,0 +1,13 @@
+package org.apache.openejb.arquillian.tests.jaxrs.spring;
Review Comment:
Missing header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/AlternativeGreeter.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.openejb.arquillian.tests.jaxrs.spring;
Review Comment:
Missing header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/ServletInitializer.java:
##########
@@ -0,0 +1,13 @@
+package org.apache.openejb.arquillian.tests.jaxrs.spring;
Review Comment:
Missing header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml:
##########
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
Missing header
##########
arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml:
##########
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-starter-parent</artifactId>
+ <version>3.1.11</version>
Review Comment:
Spring Boot 3 has a Java 17 baseline, so this will likely fail the Java 11 based build. I think, that we would need to build an exclusion for that test if we run with a runtime below 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE w… (tomee)
Posted by "venkat9 (via GitHub)" <gi...@apache.org>.
venkat9 commented on PR #1165:
URL: https://github.com/apache/tomee/pull/1165#issuecomment-2126704134
may i know how to contribute something to this project.. any project setup
guide etc.
On Thu, May 23, 2024 at 3:25 PM Jonathan Gallimore ***@***.***>
wrote:
> …hen the cxf-rs service is initialized
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/tomee/pull/1165
> Commit Summary
>
> - ff60d0d
> <https://github.com/apache/tomee/pull/1165/commits/ff60d0d399aec35d8bdfbadd52e105ed008efccf>
> TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE when
> the cxf-rs service is initialized
>
> File Changes
>
> (9 files <https://github.com/apache/tomee/pull/1165/files>)
>
> - *M*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/pom.xml
> <https://github.com/apache/tomee/pull/1165/files#diff-84a03152e5e61c4c8eb0fd789255924913a5282b110b39dd54fffc374dd7a2f4>
> (22)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/AlternativeGreeter.java
> <https://github.com/apache/tomee/pull/1165/files#diff-42b4bf19f1fd00c42fd9c614651849f16953751549621f02091afe5b7928cecb>
> (22)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/DemoApplication.java
> <https://github.com/apache/tomee/pull/1165/files#diff-8445dba18580221bb63a940955a737356a510f48c35479bbcd0441bff673a72f>
> (13)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/GreetingController.java
> <https://github.com/apache/tomee/pull/1165/files#diff-b6dae7952f5efabf54144fdd858fc68b278943f9f47a0aa5a0a2f958678bb7be>
> (19)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/ServletInitializer.java
> <https://github.com/apache/tomee/pull/1165/files#diff-dc56cf14f0a93124da840cd246e8b4134ed2a8824ee6e1438695f1a92e121953>
> (13)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/spring/SpringWebappTest.java
> <https://github.com/apache/tomee/pull/1165/files#diff-c2daf3f2afe8f5d3568572e30c3a9c1c40f617c091c9296dead7b4325e00596c>
> (158)
> - *A*
> arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/resources/spring-webmvc-pom.xml
> <https://github.com/apache/tomee/pull/1165/files#diff-cca184508061abf53c1b71496a9102638983dd5db48f48e3647f9b008ac78f45>
> (44)
> - *M* arquillian/arquillian-tomee-tests/pom.xml
> <https://github.com/apache/tomee/pull/1165/files#diff-a2f5f4c3f55990b49f7027a8ec8ebc454867bbb1f330f56f1708d61aa1bc114a>
> (1)
> - *M*
> server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRSService.java
> <https://github.com/apache/tomee/pull/1165/files#diff-03a49e7161ba61df5ee2131dcb82aef56a3dbebd671928e25dfd3fcff9180c0c>
> (6)
>
> Patch Links:
>
> - https://github.com/apache/tomee/pull/1165.patch
> - https://github.com/apache/tomee/pull/1165.diff
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomee/pull/1165>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABL6BELFJT42EDWFXUBUG4LZDW4INAVCNFSM6AAAAABIFJPXOSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTENBXGQ3DGOI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TOMEE-4332 Load SpringWebUtils in the context class loader in TomEE w… (tomee)
Posted by "jgallimore (via GitHub)" <gi...@apache.org>.
jgallimore commented on PR #1165:
URL: https://github.com/apache/tomee/pull/1165#issuecomment-2126716747
@venkat9 Your best bet is to join the users mailing list, and ask your question there. Best suggestion I can give concisely is to use TomEE, and if you identify bugs, discuss them on the mailing list with a view to fixing. Similarly, if you can see a feature you'd enjoy implementing, discuss that on the mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org