Re: [PR] Allow optional segments that can be skipped by servers without failing the query [pinot]

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11978:
URL: https://github.com/apache/pinot/pull/11978#discussion_r1395012284


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -594,6 +594,10 @@ protected BrokerResponse handleRequest(long requestId, String query, @Nullable S
       long routingStartTimeNs = System.nanoTime();
       Map<ServerInstance, List<String>> offlineRoutingTable = null;
       Map<ServerInstance, List<String>> realtimeRoutingTable = null;
+      Map<ServerInstance, List<String>> optionalOfflineRoutingTable = null;
+      Map<ServerInstance, List<String>> optionalRealtimeRoutingTable = null;
+      Set<ServerInstance> offlineServerInstances = null;
+      Set<ServerInstance> realtimeServerInstances = null;

Review Comment:
   It is much simpler if we change routing table to `Map<ServerInstance, Pair<List<String>, List<String>>` where the first list is mandatory segments and the second list is option segments. We may also change the `RoutingTable._serverInstanceToSegmentsMap` type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org