You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/10/01 15:26:15 UTC
[PR] fix(web): pin the DLQ drawer to the time range it was opened with [rocketmq-dashboard]
Frun1na opened a new pull request, #5293:
URL: https://github.com/apache/rocketmq-dashboard/pull/5293
### Which Issue(s) This PR Fixes
- Fixes #5292
### Brief Description
The drawer read the live group-level `exportRange` for its banner, its reload and its export, while the table kept the rows loaded at open time. Changing the picker mid-session therefore showed one window in the banner, another in the table and a third in the downloaded file. The drawer now snapshots the range at open (`detailRange`) and uses it for load, banner and export; closing and reopening applies the new range.
### How Did You Test This Change?
```
cd web && npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx
Test Files 1 passed (1)
Tests 22 passed (22)
```
---
Re-submission of #4929: the original PR was closed by the stale bot after 7 days without review activity, and GitHub now rejects reopening pull requests in this repository ("state cannot be changed"), so the same change is re-submitted rebased onto the current `rocketmq-studio` tip (`a460673f`). The original review thread stays available at #4929.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): pin the DLQ drawer to the time range it was opened with [rocketmq-dashboard]
Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5293:
URL: https://github.com/apache/rocketmq-dashboard/pull/5293#issuecomment-6093179173
Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): pin the DLQ drawer to the time range it was opened with [rocketmq-dashboard]
Posted by "Frun1na (via GitHub)" <gi...@apache.org>.
Frun1na commented on PR #5293:
URL: https://github.com/apache/rocketmq-dashboard/pull/5293#issuecomment-6044119328
Friendly ping — this is still open for review whenever you get a chance. (Keeping it from the stale bot for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org