You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Bill Havanki <bh...@clouderagovt.com> on 2014/06/09 22:47:15 UTC
Review Request 22399: ACCUMULO-2876 - use site config for default
VolumeManagerImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/
-----------------------------------------------------------
Review request for accumulo, Eric Newton and Josh Elser.
Bugs: ACCUMULO-2876
https://issues.apache.org/jira/browse/ACCUMULO-2876
Repository: accumulo
Description
-------
This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based system configuration. This seems to align better with what is intended, and it also eliminates the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance ID, which requires a volume manager.
Diffs
-----
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579
Diff: https://reviews.apache.org/r/22399/diff/
Testing
-------
All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring for ACCUMULO-2615.
Thanks,
Bill Havanki
Re: Review Request 22399: ACCUMULO-2876 - use site config for default
VolumeManagerImpl
Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/#review45135
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Newton
On June 9, 2014, 8:47 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22399/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 8:47 p.m.)
>
>
> Review request for accumulo, Eric Newton and Josh Elser.
>
>
> Bugs: ACCUMULO-2876
> https://issues.apache.org/jira/browse/ACCUMULO-2876
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based system configuration. This seems to align better with what is intended, and it also eliminates the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance ID, which requires a volume manager.
>
>
> Diffs
> -----
>
> server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579
>
> Diff: https://reviews.apache.org/r/22399/diff/
>
>
> Testing
> -------
>
> All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring for ACCUMULO-2615.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 22399: ACCUMULO-2876 - use site config for default
VolumeManagerImpl
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On June 9, 2014, 4:59 p.m., Josh Elser wrote:
> > Please make a follow-on for making Property.GENERAL_VOLUME_CHOOSER a fixed property since you didn't make that change here. Thanks.
Will do.
/me presses Publish. :)
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/#review45139
-----------------------------------------------------------
On June 9, 2014, 4:47 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22399/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 4:47 p.m.)
>
>
> Review request for accumulo, Eric Newton and Josh Elser.
>
>
> Bugs: ACCUMULO-2876
> https://issues.apache.org/jira/browse/ACCUMULO-2876
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based system configuration. This seems to align better with what is intended, and it also eliminates the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance ID, which requires a volume manager.
>
>
> Diffs
> -----
>
> server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579
>
> Diff: https://reviews.apache.org/r/22399/diff/
>
>
> Testing
> -------
>
> All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring for ACCUMULO-2615.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 22399: ACCUMULO-2876 - use site config for default
VolumeManagerImpl
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/#review45139
-----------------------------------------------------------
Ship it!
Please make a follow-on for making Property.GENERAL_VOLUME_CHOOSER a fixed property since you didn't make that change here. Thanks.
- Josh Elser
On June 9, 2014, 8:47 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22399/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 8:47 p.m.)
>
>
> Review request for accumulo, Eric Newton and Josh Elser.
>
>
> Bugs: ACCUMULO-2876
> https://issues.apache.org/jira/browse/ACCUMULO-2876
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based system configuration. This seems to align better with what is intended, and it also eliminates the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance ID, which requires a volume manager.
>
>
> Diffs
> -----
>
> server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579
>
> Diff: https://reviews.apache.org/r/22399/diff/
>
>
> Testing
> -------
>
> All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring for ACCUMULO-2615.
>
>
> Thanks,
>
> Bill Havanki
>
>