You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/09/01 15:20:07 UTC

[jira] [Created] (AMQ-4011) Refactor IntrospectionSupport to avoid using java bean property editors

Claus Ibsen created AMQ-4011:
--------------------------------

             Summary: Refactor IntrospectionSupport to avoid using java bean property editors
                 Key: AMQ-4011
                 URL: https://issues.apache.org/jira/browse/AMQ-4011
             Project: ActiveMQ
          Issue Type: Improvement
          Components: Broker
    Affects Versions: 5.6.0
            Reporter: Claus Ibsen
            Assignee: Claus Ibsen


Java bean property editors is slow and not thread safe to use. We at Apache Camel has removed its usage in the Camel type converter system.

We should do the same in ActiveMQ. There is only a number of default converters needed that is fairly easy to implement by hand (eg String <-> Numbers, Booleans etc.). 

This fixes some other issues with AMQ causing memory leaks in dynamic environments where you may run multiple brokers, or hot deploy brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (AMQ-4011) Refactor IntrospectionSupport to avoid using java bean property editors

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved AMQ-4011.
------------------------------

    Resolution: Fixed
    
> Refactor IntrospectionSupport to avoid using java bean property editors
> -----------------------------------------------------------------------
>
>                 Key: AMQ-4011
>                 URL: https://issues.apache.org/jira/browse/AMQ-4011
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>
> Java bean property editors is slow and not thread safe to use. We at Apache Camel has removed its usage in the Camel type converter system.
> We should do the same in ActiveMQ. There is only a number of default converters needed that is fairly easy to implement by hand (eg String <-> Numbers, Booleans etc.). 
> This fixes some other issues with AMQ causing memory leaks in dynamic environments where you may run multiple brokers, or hot deploy brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4011) Refactor IntrospectionSupport to avoid using java bean property editors

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457678#comment-13457678 ] 

Claus Ibsen commented on AMQ-4011:
----------------------------------

I have kept 2 special converters for backwards compatibility
- Object <-> String[]
- String <-> List<ActiveMQDestination>

In the future we may want to see if we can discourage using them. Especially the latter which is a bit special. As there is type erasure we don't really know that you want a List<ActiveMQDestination> and not a List<Foo> etc.

                
> Refactor IntrospectionSupport to avoid using java bean property editors
> -----------------------------------------------------------------------
>
>                 Key: AMQ-4011
>                 URL: https://issues.apache.org/jira/browse/AMQ-4011
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>
> Java bean property editors is slow and not thread safe to use. We at Apache Camel has removed its usage in the Camel type converter system.
> We should do the same in ActiveMQ. There is only a number of default converters needed that is fairly easy to implement by hand (eg String <-> Numbers, Booleans etc.). 
> This fixes some other issues with AMQ causing memory leaks in dynamic environments where you may run multiple brokers, or hot deploy brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4011) Refactor IntrospectionSupport to avoid using java bean property editors

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457080#comment-13457080 ] 

Claus Ibsen commented on AMQ-4011:
----------------------------------

xbean requires to use property editors for its xml -> int|long|boolean conversions.

However the IntrospectionSupport which is used during runtime, should avoid property editors.
                
> Refactor IntrospectionSupport to avoid using java bean property editors
> -----------------------------------------------------------------------
>
>                 Key: AMQ-4011
>                 URL: https://issues.apache.org/jira/browse/AMQ-4011
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>
> Java bean property editors is slow and not thread safe to use. We at Apache Camel has removed its usage in the Camel type converter system.
> We should do the same in ActiveMQ. There is only a number of default converters needed that is fairly easy to implement by hand (eg String <-> Numbers, Booleans etc.). 
> This fixes some other issues with AMQ causing memory leaks in dynamic environments where you may run multiple brokers, or hot deploy brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-4011) Refactor IntrospectionSupport to avoid using java bean property editors

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated AMQ-4011:
-----------------------------

    Fix Version/s: 5.7.0
    
> Refactor IntrospectionSupport to avoid using java bean property editors
> -----------------------------------------------------------------------
>
>                 Key: AMQ-4011
>                 URL: https://issues.apache.org/jira/browse/AMQ-4011
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>
> Java bean property editors is slow and not thread safe to use. We at Apache Camel has removed its usage in the Camel type converter system.
> We should do the same in ActiveMQ. There is only a number of default converters needed that is fairly easy to implement by hand (eg String <-> Numbers, Booleans etc.). 
> This fixes some other issues with AMQ causing memory leaks in dynamic environments where you may run multiple brokers, or hot deploy brokers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira