You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/25 01:36:21 UTC

[GitHub] [ozone] umamaheswararao commented on a change in pull request #3016: HDDS-6220. EC: Introduce a gRPC client implementation for EC with really async WriteChunk and PutBlock.

umamaheswararao commented on a change in pull request #3016:
URL: https://github.com/apache/ozone/pull/3016#discussion_r791287149



##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -470,6 +470,11 @@ public XceiverClientReply sendCommandAsync(
     }
   }
 

Review comment:
       A minor comment: Please provide some documentation something like "sendCommandAsync uses this API to decide whether command to work in async mode or in sync mode. In XceiverClientGrpc, read requests are async and write requests are sync. So, this method should return true for write commands and false for read."
   
   So, in overridden EC specific API can document about both write and read should be in sync.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org