You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/28 05:11:50 UTC
Review Request 27248: SQOOP-1629:Add unique constraint on the Config
table for name and type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:16 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java, lines 765-770
> > <https://reviews.apache.org/r/27248/diff/3/?file=735162#file735162line765>
> >
> > There seem to be unnecessary breaks. Can't this be mostly all one string?
lazy to do manual align and IDE is not set up for the SQL query prety aligning
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58774
-----------------------------------------------------------
On Oct. 27, 2014, 11:12 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 11:12 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58774
-----------------------------------------------------------
Ship it!
Looks good besides these nits.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99939>
one line?
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99937>
There seem to be unnecessary breaks. Can't this be mostly all one string?
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99940>
one line?
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99938>
Same as above.
- Abraham Elmahrek
On Oct. 28, 2014, 6:12 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 6:12 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58944
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 29, 2014, 12:24 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 12:24 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 5:24 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 4:59 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58923
-----------------------------------------------------------
Ship it!
Saw one more thing that I think we should change and it's in!
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
<https://reviews.apache.org/r/27248/#comment100106>
Change name? E.g. SQ_CFG_NAME_TYPE_CONFIGURABLE
- Abraham Elmahrek
On Oct. 28, 2014, 11:04 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 11:04 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 4:04 p.m.)
Review request for Sqoop.
Changes
-------
format the entire derby test case file.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 3:59 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 3:52 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 3:23 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 28, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java, lines 782-785
> > <https://reviews.apache.org/r/27248/diff/6-8/?file=735205#file735205line782>
> >
> > spacing seems off here.
i have used the IDE formatting
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58891
-----------------------------------------------------------
On Oct. 28, 2014, 2:05 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 2:05 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 28, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java, lines 96-104
> > <https://reviews.apache.org/r/27248/diff/6-8/?file=735208#file735208line96>
> >
> > With the three columns, there are 2^8 combinations that should be tested? (Name, Type, configurable ID):
> > 1. Same name
> > 2. Same type
> > 3. Same configurable
> > 4. Same name and type
> > 5. Same name and configurable
> > 6. Sam type and configurable
> > 7. same name, type, and configurable
> > 8. Nothing the same
> >
> > Cool to add later though. Can we create a Jira to add test cases for this?
not sure each of those are valid uses cases. There is no need ot stress test the database constaints IMO
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58891
-----------------------------------------------------------
On Oct. 28, 2014, 2:05 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 2:05 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58891
-----------------------------------------------------------
Ship it!
Careful with extra white spaces. Also, a few nits.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment100039>
nam => name
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment100041>
spacing seems off here.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java
<https://reviews.apache.org/r/27248/#comment100046>
With the three columns, there are 2^8 combinations that should be tested? (Name, Type, configurable ID):
1. Same name
2. Same type
3. Same configurable
4. Same name and type
5. Same name and configurable
6. Sam type and configurable
7. same name, type, and configurable
8. Nothing the same
Cool to add later though. Can we create a Jira to add test cases for this?
Careful
- Abraham Elmahrek
On Oct. 28, 2014, 9:05 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 9:05 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 2:05 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 2:03 p.m.)
Review request for Sqoop.
Changes
-------
addressed a very imp comment from Abe ( see jirs for details). added relevant tests
Repository: sqoop-sqoop2
Description
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58816
-----------------------------------------------------------
So I did miss something here. Shouldn't the config be unique per name + connector?
- Abraham Elmahrek
On Oct. 28, 2014, 3:49 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 3:49 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
>
> Note I have rebased to the latest on 28th morning/
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 8:49 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description (updated)
-------
see jira
Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs
Note I have rebased to the latest on 28th morning/
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 8:47 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description (updated)
-------
see jira
Note I have rebased to the latest on 28th morning/
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 11:29 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 11:24 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 11:12 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java, line 144
> > <https://reviews.apache.org/r/27248/diff/2/?file=735127#file735127line144>
> >
> > There are two underscores.
vow that was good catch at night.!
> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java, line 127
> > <https://reviews.apache.org/r/27248/diff/2/?file=735131#file735131line127>
> >
> > configName2 isn't used
but this class overrides the base class method. did not want to break that signature
> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java, line 413
> > <https://reviews.apache.org/r/27248/diff/2/?file=735129#file735129line413>
> >
> > We should probably move a lot of this out to a utility class. Can we address this in another Jira? Class inheritance works for now.
yes I will add a comment in the ticket I ahve for test clean up. I jsut saw Chelsoo Park have the same thing about this test file
https://issues.apache.org/jira/browse/SQOOP-1583
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58770
-----------------------------------------------------------
On Oct. 27, 2014, 10:40 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:40 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 27, 2014, 11:04 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java, line 413
> > <https://reviews.apache.org/r/27248/diff/2/?file=735129#file735129line413>
> >
> > We should probably move a lot of this out to a utility class. Can we address this in another Jira? Class inheritance works for now.
>
> Veena Basavaraj wrote:
> yes I will add a comment in the ticket I ahve for test clean up. I jsut saw Chelsoo Park have the same thing about this test file
>
> https://issues.apache.org/jira/browse/SQOOP-1583
https://issues.apache.org/jira/browse/SQOOP-823
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58770
-----------------------------------------------------------
On Oct. 27, 2014, 10:40 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:40 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58770
-----------------------------------------------------------
A few nits here and there buy looks good.
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
<https://reviews.apache.org/r/27248/#comment99927>
There are two underscores.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
<https://reviews.apache.org/r/27248/#comment99932>
We should probably move a lot of this out to a utility class. Can we address this in another Jira? Class inheritance works for now.
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99931>
configName2 isn't used
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99930>
NIT: Spacing is a little weird
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
<https://reviews.apache.org/r/27248/#comment99929>
NIT: Spacing is a little weird
- Abraham Elmahrek
On Oct. 28, 2014, 5:40 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 5:40 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
>
> Diff: https://reviews.apache.org/r/27248/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 10:40 p.m.)
Review request for Sqoop.
Changes
-------
rebased
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java e584a19
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27248: SQOOP-1629:Add unique constraint on the
Config table for name and type
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 9:13 p.m.)
Review request for Sqoop.
Changes
-------
remove a WS I missed earlier
Repository: sqoop-sqoop2
Description
-------
see jira
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 7f19c28
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java edcef70
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7
Diff: https://reviews.apache.org/r/27248/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj