You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/09 17:12:52 UTC

[GitHub] [arrow] kiszk commented on a change in pull request #8147: ARROW-9680: [Java] Support non-nullable vectors

kiszk commented on a change in pull request #8147:
URL: https://github.com/apache/arrow/pull/8147#discussion_r485785372



##########
File path: java/vector/src/main/java/org/apache/arrow/vector/IntVector.java
##########
@@ -164,7 +165,9 @@ private void setValue(int index, int value) {
    * @param value value of element
    */
   public void set(int index, int value) {
-    BitVectorHelper.setBit(validityBuffer, index);
+    if (!NON_NULLABLE_VECTORS_ENABLED || nullable) {

Review comment:
       Can we declare `NON_NULLABLE_VECTORS_ENABLED && nullable` as a final instance variable?  If so, we can avoid a similar conditional expression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org