You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by robertwb <gi...@git.apache.org> on 2017/01/31 20:51:41 UTC

[GitHub] beam pull request #1884: Reduce cost of sample combine test

GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/1884

    Reduce cost of sample combine test

    There's no need to run this test 300 times, which takes tens of seconds.
    
    Also split global and per-key sampling into separate tests.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam patch-4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1884
    
----
commit 7f266ff0835efb96e55785f2a2eb93e4eab9224c
Author: Robert Bradshaw <ro...@gmail.com>
Date:   2017-01-31T20:51:27Z

    Reduce cost of sample combine test
    
    There's no need to run this test 300 times, which takes tens of seconds.
    
    Also split global and per-key sampling into separate tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1884: [BEAM-1371] Reduce cost of sample combine test

Posted by robertwb <gi...@git.apache.org>.
Github user robertwb closed the pull request at:

    https://github.com/apache/beam/pull/1884


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---