[GitHub] [spark] Ngone51 commented on a change in pull request #26863: [SPARK-30234][SQL] ADD FILE cannot add directories from sql CLI

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #26863: [SPARK-30234][SQL] ADD FILE cannot add directories from sql CLI
URL: https://github.com/apache/spark/pull/26863#discussion_r378715586
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -2147,6 +2147,12 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val LEGACY_ADD_DIRECTORY_USING_RECURSIVE = buildConf("spark.sql.legacy.addDirectory.recursive")
 
 Review comment:
   Hey guys, I think the config is not consistent between name and default value.
   
   If we want it to be a real legacy config, then, I think its name should be like `spark.sql.legacy.addSingleFileInAddFile` and default to `false`. If not, then, we may name it as `spark.sql.allowAddDirectoryInAddFile` and default to `true`.
   
   Any ideas? @maropu @iRakson 
   
   BTW, I'm going to revise a batch of boolean configs in order to comply with our [new config name policy](http://apache-spark-developers-list.1001551.n3.nabble.com/DISCUSS-naming-policy-of-Spark-configs-td28875.html). So, I'll address the consensus here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org