You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/27 21:53:19 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1379: nimble/transport: Add generic IPC transport with flow control
andrzej-kaczmarek opened a new pull request, #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379
This adds generic IPC transport that should be used as a base for any transport with LL on separate core. It's similar to HCI H4, but has a bit different header to simplify processing and supports internal flow control to make sure LL does not send data that other core does not have free buffers for.
IPC transport requires memory shared between cores to keep track of number of available buffers on application core. Application core will initialize counters to total number of available buffers. Then on each alloc LL will atomically test and decrease relevan counter and will allocate buffer only if that counter was non-zero. The counter will be increased by application core if relevant buffer was freed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1263636722
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1261382464
requires also some core changes: https://github.com/apache/mynewt-core/pull/2889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1261424400
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/transport/common/hci_ipc/src/hci_ipc.c
<details>
```diff
@@ -84,7 +84,7 @@
switch (sm->hdr.type) {
#if MYNEWT_VAL(BLE_CONTROLLER)
- case HCI_IPC_TYPE_CMD:
+ case HCI_IPC_TYPE_CMD:
ble_transport_to_ll_cmd(sm->buf);
break;
#endif
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1263538105
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1262097981
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1260094540
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/transport/nrf5340/src/nrf5340_ble_hci.c
<details>
```diff
@@ -86,7 +86,7 @@
ble_transport_to_hs_evt_impl(void *buf)
{
uint8_t ind = HCI_IPC_TYPE_EVT;
- uint8_t* hci_ev = buf;
+ uint8_t * hci_ev = buf;
int len = 2 + hci_ev[1];
int rc;
@@ -167,7 +167,7 @@
" cmp r1, #0 \n"
" bne 1b \n"
: [ret] "=&r" (ret)
- : [addr] "r"(num)
+ : [addr] "r" (num)
: "r1", "r2", "memory");
return ret;
@@ -183,6 +183,6 @@
" cmp r2, #0 \n"
" bne 1b \n"
:
- : [addr] "r"(num)
+ : [addr] "r" (num)
: "r1", "r2", "memory");
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1262027479
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/transport/common/hci_ipc/src/hci_ipc.c
<details>
```diff
@@ -84,7 +84,7 @@
switch (sm->hdr.type) {
#if MYNEWT_VAL(BLE_CONTROLLER)
- case HCI_IPC_TYPE_CMD:
+ case HCI_IPC_TYPE_CMD:
ble_transport_to_ll_cmd(sm->buf);
break;
#endif
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1379: nimble/transport: Add generic IPC transport with flow control
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1379:
URL: https://github.com/apache/mynewt-nimble/pull/1379#issuecomment-1260102087
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org