[GitHub] eolivelli commented on a change in pull request #1236: Issue #570: make changes to SyncThread/checkpoint logic.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1236: Issue #570: make changes to SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r173613889
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -696,14 +698,29 @@ public Bookie(ServerConfiguration conf, StatsLogger statsLogger)
         ledgerStorage = LedgerStorageFactory.createLedgerStorage(ledgerStorageClass);
         syncThread = new SyncThread(conf, getLedgerDirsListener(), ledgerStorage, checkpointSource);
 
+        Checkpointer checkpointer;
+        /*
+         * with this change https://github.com/apache/bookkeeper/pull/677,
+         * LedgerStorage drives the checkpoint logic. But with multiple entry
+         * logs, checkpoint logic based on a entry log is not possible, hence it
+         * needs to be timebased recurring thing and it is driven by SyncThread.
+         * SyncThread.start does that and it is started in Bookie.start method.
+         */
+        if (entryLogPerLedgerEnabled) {
 
 Review comment:
   I had the same idea as @ivankelly but I never clocked on 'submit' review.
   So +1 for me for having a common base class. But this is not blocker for me

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services