You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by dnfield <gi...@git.apache.org> on 2017/10/05 18:19:43 UTC
[GitHub] cordova-plugin-screen-orientation pull request #24: CB-13405: (ios) Go to la...
GitHub user dnfield opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24
CB-13405: (ios) Go to last used orientation before locking when unlocking screen on iOS
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dnfield/cordova-plugin-screen-orientation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 114aeef0bb79478098669594e7207357ffcc7644
Author: Dan Field <dn...@travelers.com>
Date: 2017-10-05T18:13:26Z
CB-13405: (ios) Screen unlock bug fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-screen-orientation pull request #24: CB-13405: (ios) Go to la...
Posted by dnfield <gi...@git.apache.org>.
GitHub user dnfield reopened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24
CB-13405: (ios) Go to last used orientation before locking when unlocking screen on iOS
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dnfield/cordova-plugin-screen-orientation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 114aeef0bb79478098669594e7207357ffcc7644
Author: Dan Field <dn...@travelers.com>
Date: 2017-10-05T18:13:26Z
CB-13405: (ios) Screen unlock bug fix
commit b4db5e2796abf7a773b8e644f55e9457c221693a
Author: Dan Field <dn...@travelers.com>
Date: 2017-10-05T19:16:07Z
CB-13405: (ios) undo lock when resetting
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-screen-orientation pull request #24: CB-13405: (ios) Go to la...
Posted by dnfield <gi...@git.apache.org>.
Github user dnfield closed the pull request at:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-screen-orientation issue #24: CB-13405: (ios) Go to last used...
Posted by dnfield <gi...@git.apache.org>.
Github user dnfield commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/24
This isn't quite ready.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org