You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/17 20:12:28 UTC
Review Request 72782: Added RE2 to the CMake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72782/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10170
https://issues.apache.org/jira/browse/MESOS-10170
Repository: mesos
Description
-------
This is a prerequisite for implementing regex-based offer constraints.
Diffs
-----
3rdparty/CMakeLists.txt af9a071a465dbd57b44f67949d5ec630a1a57a2e
3rdparty/cmake/Versions.cmake 93766161da14eab30f4ebf382303073aa2b6d448
3rdparty/re2-2020-07-06.tar.gz PRE-CREATION
LICENSE 2c5919d1e9b7d1377ad5982c66cef0c962308cf4
src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea
Diff: https://reviews.apache.org/r/72782/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72782: Added RE2 to the CMake build.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72782/#review221648
-----------------------------------------------------------
Ship it!
Looks like there is a newer 2020-08-01 release with 1 more commit (doesn't look too important).
- Benjamin Mahler
On Aug. 19, 2020, 6:02 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72782/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2020, 6:02 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10170
> https://issues.apache.org/jira/browse/MESOS-10170
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a prerequisite for implementing regex-based offer constraints.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt af9a071a465dbd57b44f67949d5ec630a1a57a2e
> 3rdparty/cmake/Versions.cmake 93766161da14eab30f4ebf382303073aa2b6d448
> 3rdparty/re2-2020-07-06.tar.gz PRE-CREATION
> LICENSE 2c5919d1e9b7d1377ad5982c66cef0c962308cf4
> src/CMakeLists.txt a976dc12328f42d2268b4b5d86a934bf0c754594
>
>
> Diff: https://reviews.apache.org/r/72782/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72782: Added RE2 to the CMake build.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72782/
-----------------------------------------------------------
(Updated Aug. 19, 2020, 6:02 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Replaced ifdef(WIN32) with a (potentially broken) Windows build.
Bugs: MESOS-10170
https://issues.apache.org/jira/browse/MESOS-10170
Repository: mesos
Description
-------
This is a prerequisite for implementing regex-based offer constraints.
Diffs (updated)
-----
3rdparty/CMakeLists.txt af9a071a465dbd57b44f67949d5ec630a1a57a2e
3rdparty/cmake/Versions.cmake 93766161da14eab30f4ebf382303073aa2b6d448
3rdparty/re2-2020-07-06.tar.gz PRE-CREATION
LICENSE 2c5919d1e9b7d1377ad5982c66cef0c962308cf4
src/CMakeLists.txt a976dc12328f42d2268b4b5d86a934bf0c754594
Diff: https://reviews.apache.org/r/72782/diff/2/
Changes: https://reviews.apache.org/r/72782/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko