You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/10/31 23:29:12 UTC

[jira] [Created] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Avery Ching created GIRAPH-395:
----------------------------------

             Summary: No need to make HashWorkerPartitioner thread-safe.
                 Key: GIRAPH-395
                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
             Project: Giraph
          Issue Type: Improvement
            Reporter: Avery Ching
            Assignee: Avery Ching




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avery Ching updated GIRAPH-395:
-------------------------------

    Attachment: GIRAPH-395.patch

The infrastructure ensures that this need not be thread-safe.  All compute threads that use this get it safely.
                
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510176#comment-13510176 ] 

Maja Kabiljo commented on GIRAPH-395:
-------------------------------------

+1, thanks Avery
                
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.2.patch, GIRAPH-395.patch, GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488348#comment-13488348 ] 

Maja Kabiljo commented on GIRAPH-395:
-------------------------------------

Good catch, Avery! Any reason why getPartitionOwners is synchronized and HashRangeWorkerPartitioner uses that synchronized call?
                
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510893#comment-13510893 ] 

Hudson commented on GIRAPH-395:
-------------------------------

Integrated in Giraph-trunk-Commit #303 (See [https://builds.apache.org/job/Giraph-trunk-Commit/303/])
    GIRAPH-395: No need to make HashWorkerPartitioner thread-safe. (aching) (Revision 1417250)

     Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1417250
Files : 
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java

                
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.2.patch, GIRAPH-395.patch, GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avery Ching updated GIRAPH-395:
-------------------------------

    Attachment: GIRAPH-395.patch

Got rid of the synchronized.
                
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.patch, GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (GIRAPH-395) No need to make HashWorkerPartitioner thread-safe.

Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avery Ching updated GIRAPH-395:
-------------------------------

    Attachment: GIRAPH-395.2.patch
    
> No need to make HashWorkerPartitioner thread-safe.
> --------------------------------------------------
>
>                 Key: GIRAPH-395
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-395
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-395.2.patch, GIRAPH-395.patch, GIRAPH-395.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira