[GitHub] mistercrunch commented on a change in pull request #3907: In Bubble Chart, avoid X Axis, Y Axis duplicate name, caused ValueErr?

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #3907: In Bubble Chart, avoid X Axis, Y Axis duplicate name, caused ValueErr?
URL: https://github.com/apache/incubator-superset/pull/3907#discussion_r152044349
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -787,8 +787,8 @@ def query_obj(self):
         return d
 
     def get_data(self, df):
-        df['x'] = df[[self.x_metric]]
-        df['y'] = df[[self.y_metric]]
+        df['x'] = df[[self.x_metric]].ix[:, 0]
+        df['y'] = df[[self.y_metric]].ix[:, 0]
 
 Review comment:
   I've written a fair amount of pandas and I'm unclear what this does... Should we just raise above in `query_obj` when `self.x_metric == self.y_metric` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services