You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/04 10:38:10 UTC
[GitHub] [netbeans] dbalek opened a new pull request #3406: VSCode: Show Debug Console while running tests.
dbalek opened a new pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406
Show Debug Console while running tests to display possible compilation errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #3406: VSCode: Show Debug Console while running tests.
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406#discussion_r778764278
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
originally this seemed awkward, but activates only if `testProgress` sets it to true during one of the `await`s - right ?
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
Shouldn't be `cancellation` checked also in the 1st branch (line ~65)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #3406: VSCode: Show Debug Console while running tests.
Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a change in pull request #3406: VSCode: Show Debug Console while running tests.
Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406#discussion_r778827412
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
Yes this change prevents tests to be marked as skipped in case they are not even started (e.g. due to a compilation error).
Code modified to check `cancellation` in the first branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists