[GitHub] andrzej-kaczmarek commented on issue #755: nimble: mbuf optimization in controller

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on issue #755: nimble: mbuf optimization in controller
URL: https://github.com/apache/mynewt-core/pull/755#issuecomment-359574207
 
 
   Thanks for review, @wes3. Indeed, I missed both cases so will need to address this.
   
   In case of os_mbuf_append failure (or oom in general) we should remove all adv_data as per spec.
   
   As for TX I assumed here that since we just change order of operations and reduce time required to create buffer in some cases it should not affect this, but I'll move check for radio state after filling header bytes and see results in tx_late stat. So far I did not observe any regressions with advertising/connection so hopefully my assumption was correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services