You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 08:45:08 UTC

[GitHub] [airflow] theodor1289 opened a new issue #10575: Confusing parameter

theodor1289 opened a new issue #10575:
URL: https://github.com/apache/airflow/issues/10575


   https://github.com/apache/airflow/blob/3a349624a20d3432dc75e337d6ffb1109a50e451/airflow/providers/amazon/aws/operators/athena.py#L49
   
   What is the unit of measurement of time used here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] XD-DENG closed issue #10575: Confusing parameter

Posted by GitBox <gi...@apache.org>.
XD-DENG closed issue #10575:
URL: https://github.com/apache/airflow/issues/10575


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #10575: Confusing parameter

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #10575:
URL: https://github.com/apache/airflow/issues/10575#issuecomment-680746134


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] theodor1289 edited a comment on issue #10575: Confusing parameter

Posted by GitBox <gi...@apache.org>.
theodor1289 edited a comment on issue #10575:
URL: https://github.com/apache/airflow/issues/10575#issuecomment-680846281


   Just checked and it's [simply using](https://github.com/apache/airflow/blob/3a349624a20d3432dc75e337d6ffb1109a50e451/airflow/providers/amazon/aws/hooks/athena.py#L229) the Python method sleep() in library time which, in turn, [uses seconds](https://docs.python.org/3/library/time.html#time.sleep). I'll make the change in the docstring then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] coopergillan commented on issue #10575: Confusing parameter

Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #10575:
URL: https://github.com/apache/airflow/issues/10575#issuecomment-680822196


   I'm almost certain that is seconds. That would be a good change for the docstring.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] theodor1289 commented on issue #10575: Confusing parameter

Posted by GitBox <gi...@apache.org>.
theodor1289 commented on issue #10575:
URL: https://github.com/apache/airflow/issues/10575#issuecomment-680846281


   Just checked and it's [simply using](https://github.com/apache/airflow/blob/3a349624a20d3432dc75e337d6ffb1109a50e451/airflow/providers/amazon/aws/hooks/athena.py#L229) the Python method sleep() which, in turn, [uses seconds](https://docs.python.org/3/library/time.html#time.sleep). I'll make the change in the docstring then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org