[GitHub] [incubator-superset] 0xBADBAC0N commented on a change in pull request #10084: fix: Fixed bug for issue #9967 ( Hive date functions for group functions in charts )

[GitBox <gi...@apache.org>]

0xBADBAC0N commented on a change in pull request #10084:
URL: https://github.com/apache/incubator-superset/pull/10084#discussion_r446075194



##########
File path: tests/db_engine_specs/hive_tests.py
##########
@@ -16,6 +16,10 @@
 # under the License.
 from unittest import mock
 
+from pyhive import hive
+from sqlalchemy import column
+from sqlalchemy.dialects import *

Review comment:
       Hi,
   is there a specific reason to have an import star? Otherwise, I personally would prefer single imports :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org