You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "mynk2611 (via GitHub)" <gi...@apache.org> on 2025/10/17 09:12:34 UTC
[PR] fix(lines): Fix lines effect symbol flip on unidirectional loop end. close #20216 [echarts]
mynk2611 opened a new pull request, #21320:
URL: https://github.com/apache/echarts/pull/21320
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fixes an unwanted visual glitch where the effect symbol briefly reverses direction at the endpoint when using unidirectional looping animation in series-lines
### Fixed issues
<!--
- #20216 : ...
-->
## Details
### Before: What was the problem?
In unidirectional loop mode (roundTrip: false), the symbol (arrow) briefly flipped its direction backward for a single frame upon reaching the end of the path (t=1), creating an unwanted visual 'flash' before resetting to the origin.
https://github.com/user-attachments/assets/7cc46f9c-fc2a-42c4-8898-eceef1bcacb7
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How does it behave after the fixing?
The symbol now maintains its forward direction and rotation smoothly until the loop resets, eliminating the brief directional flip and ensuring a consistent unidirectional animation.
https://github.com/user-attachments/assets/906b94bd-c8ba-4226-a074-3414929c3cbe
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(lines): Fix lines effect symbol flip on unidirectional loop end. close #20216 [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21320:
URL: https://github.com/apache/echarts/pull/21320#issuecomment-3414561974
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(lines): Fix lines effect symbol flip on unidirectional loop end. close #20216 [echarts]
Posted by "Justin-ZS (via GitHub)" <gi...@apache.org>.
Justin-ZS commented on PR #21320:
URL: https://github.com/apache/echarts/pull/21320#issuecomment-3440871863
you should not change the code style.（indentation）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(lines): fix effect symbol flip on unidirectional loop end when `roundTrip` is not enabled [echarts]
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart merged PR #21320:
URL: https://github.com/apache/echarts/pull/21320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(lines): fix effect symbol flip on unidirectional loop end when `roundTrip` is not enabled [echarts]
Posted by "mynk2611 (via GitHub)" <gi...@apache.org>.
mynk2611 commented on PR #21320:
URL: https://github.com/apache/echarts/pull/21320#issuecomment-3441625409
> you should not change the code style.（indentation）
sorry about that, my editor auto-formatted the file. i'll make sure to avoid next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(lines): fix effect symbol flip on unidirectional loop end when `roundTrip` is not enabled [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21320:
URL: https://github.com/apache/echarts/pull/21320#issuecomment-3441966468
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org