You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/06/13 19:08:10 UTC
[GitHub] [gobblin] jack-moseley opened a new pull request, #3521: [GOBBLIN-1663] Add some debug log lines around GMIP hive commit events
jack-moseley opened a new pull request, #3521:
URL: https://github.com/apache/gobblin/pull/3521
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1663
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Add some debug log lines around GMIP hive commit events to try to debug missing hive commit event issues
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Trivial
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley closed pull request #3521: [GOBBLIN-1663] Add some debug log lines around GMIP hive commit events
Posted by GitBox <gi...@apache.org>.
jack-moseley closed pull request #3521: [GOBBLIN-1663] Add some debug log lines around GMIP hive commit events
URL: https://github.com/apache/gobblin/pull/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3521: [GOBBLIN-1663] Add some debug log lines around GMIP hive commit events
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on code in PR #3521:
URL: https://github.com/apache/gobblin/pull/3521#discussion_r896083615
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -138,7 +138,9 @@ public void flush(String dbName, String tableName) throws IOException {
//iterator all execution to get the result to make sure they all succeeded
for (HashMap.Entry<List<String>, ListenableFuture<Void>> execution : executionMap.entrySet()) {
try {
+ log.debug("Start registering partition during hive write for db: " + dbName + " table: " + tableName + " partition: " + Joiner.on(",").join(execution.getKey()));
execution.getValue().get(timeOutSeconds, TimeUnit.SECONDS);
Review Comment:
As this is ascync call, even we don't call get here, the hive registration might be executed as well, and in that case, we may miss the event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org