You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/12 20:15:01 UTC
[GitHub] [incubator-pinot] kishoreg opened a new issue #5688: Improve controller rest api test
kishoreg opened a new issue #5688:
URL: https://github.com/apache/incubator-pinot/issues/5688
Every end point test does the following
- start zk
- start controller
-- run some tests
-- tear down zk
-- stop controller
This is inefficient and we can definitely run all the tests using just one integration test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] amrishlal commented on issue #5688: Improve controller rest api test
Posted by GitBox <gi...@apache.org>.
amrishlal commented on issue #5688:
URL: https://github.com/apache/incubator-pinot/issues/5688#issuecomment-730530039
I looked at the test classes under `org.apache.pinot.controller.api` package. For test classes that do `startZk(); startController()`, one option may be to create a component level `testng.xml` configuration file with `<suite>...</suite>` that would contain these test classes. This will allow for specifying a `@BeforeSuite` method to run `startZk(); startController()` once before all the suite test cases and `@AfterSuite` to run `stopController();stopZk();` after all the suite test cases.
There are also some test classes that invoke `startController()` with properties (`AccessControlTest` for example) and some test classes that don't invoke either `startZk()` or `startController()` (`ControllerFilePathProviderTest` for example), so these would not be listed in the suite.
What about other packages under `org.apache.pinot.controller` (for example `...helix.ControllerInstanceToggleTest`)? Do we want to add them to the test suite as well since these classes are also doing `startZk()` or `startController()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org