You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by st...@locus.apache.org on 2000/08/30 22:47:38 UTC

cvs commit: apache-1.3/src/support httpd.exp

stoddard    00/08/30 13:47:37

  Modified:    src/support httpd.exp
  Log:
  Export ap_configtestonly. Needed for mod_perl on AIX.
  
  Submitted By: Paul Reder
  
  Revision  Changes    Path
  1.31      +1 -0      apache-1.3/src/support/httpd.exp
  
  Index: httpd.exp
  ===================================================================
  RCS file: /home/cvs/apache-1.3/src/support/httpd.exp,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- httpd.exp	2000/03/13 21:00:41	1.30
  +++ httpd.exp	2000/08/30 20:47:37	1.31
  @@ -74,6 +74,7 @@
   ap_clear_pool
   ap_clear_table
   ap_close_piped_log
  +ap_configtestonly
   ap_construct_server
   ap_construct_url
   ap_content_type_tolower
  
  
  

Re: cvs commit: apache-1.3/src/support httpd.exp

Posted by Bill Stoddard <st...@raleigh.ibm.com>.
> > I spoke with Doug a couple weeks ago when we were all at Covalent. The
> > cmd_parms thing is right for 2.0. For 1.3, exporting the symbol is the
> > cheapest thing to do and minimizes disruption to the code.
> >
> > So... sorry about that mixup. I misunderstood your patch, and thought it
was
> > for 2.0 (and thus the hesitancy towards exporting a global).
> >
> > I'd say: count on this for 1.3, but 2.0 can/should use a different
> > mechanism.
>
> Thanks Greg, that's fine. Does this patch also handle exporting
> ap_configtestonly on Win32? I'm not familiar with that platform.
>

Sorry I missed your original message. I'll check in the update to
apachecore.def for Win32 in a few minutes.

Bill



Re: cvs commit: apache-1.3/src/support httpd.exp

Posted by Eric Cholet <ch...@logilune.com>.
> I spoke with Doug a couple weeks ago when we were all at Covalent. The
> cmd_parms thing is right for 2.0. For 1.3, exporting the symbol is the
> cheapest thing to do and minimizes disruption to the code.
> 
> So... sorry about that mixup. I misunderstood your patch, and thought it was
> for 2.0 (and thus the hesitancy towards exporting a global).
> 
> I'd say: count on this for 1.3, but 2.0 can/should use a different
> mechanism.

Thanks Greg, that's fine. Does this patch also handle exporting
ap_configtestonly on Win32? I'm not familiar with that platform.

--
Eric


> 
> Cheers,
> -g
> 
> On Thu, Aug 31, 2000 at 11:25:02AM +0200, Eric Cholet wrote:
> > I'm not sure I follow here, I asked for this weeks ago, it was rejected
> > and I was advised to submit a patch that passes this variable through
> > cmd_parms instead of a global. I submitted the patch, but nothing happened.
> > Are you now back in favor of a global variable for this? It'd be nice
> > for us to know whether we can include this in the next version of mod_perl.
> > 
> > Thank you
> > 
> > > stoddard    00/08/30 13:47:37
> > > 
> > >   Modified:    src/support httpd.exp
> > >   Log:
> > >   Export ap_configtestonly. Needed for mod_perl on AIX.
> > >   
> > >   Submitted By: Paul Reder
> > >   
> > >   Revision  Changes    Path
> > >   1.31      +1 -0      apache-1.3/src/support/httpd.exp
> > >   
> > >   Index: httpd.exp
> > >   ===================================================================
> > >   RCS file: /home/cvs/apache-1.3/src/support/httpd.exp,v
> > >   retrieving revision 1.30
> > >   retrieving revision 1.31
> > >   diff -u -r1.30 -r1.31
> > >   --- httpd.exp 2000/03/13 21:00:41 1.30
> > >   +++ httpd.exp 2000/08/30 20:47:37 1.31
> > >   @@ -74,6 +74,7 @@
> > >    ap_clear_pool
> > >    ap_clear_table
> > >    ap_close_piped_log
> > >   +ap_configtestonly
> > >    ap_construct_server
> > >    ap_construct_url
> > >    ap_content_type_tolower
> > >   
> > 
> > --
> > Eric
> > 
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


Re: cvs commit: apache-1.3/src/support httpd.exp

Posted by Greg Stein <gs...@lyra.org>.
I spoke with Doug a couple weeks ago when we were all at Covalent. The
cmd_parms thing is right for 2.0. For 1.3, exporting the symbol is the
cheapest thing to do and minimizes disruption to the code.

So... sorry about that mixup. I misunderstood your patch, and thought it was
for 2.0 (and thus the hesitancy towards exporting a global).

I'd say: count on this for 1.3, but 2.0 can/should use a different
mechanism.

Cheers,
-g

On Thu, Aug 31, 2000 at 11:25:02AM +0200, Eric Cholet wrote:
> I'm not sure I follow here, I asked for this weeks ago, it was rejected
> and I was advised to submit a patch that passes this variable through
> cmd_parms instead of a global. I submitted the patch, but nothing happened.
> Are you now back in favor of a global variable for this? It'd be nice
> for us to know whether we can include this in the next version of mod_perl.
> 
> Thank you
> 
> > stoddard    00/08/30 13:47:37
> > 
> >   Modified:    src/support httpd.exp
> >   Log:
> >   Export ap_configtestonly. Needed for mod_perl on AIX.
> >   
> >   Submitted By: Paul Reder
> >   
> >   Revision  Changes    Path
> >   1.31      +1 -0      apache-1.3/src/support/httpd.exp
> >   
> >   Index: httpd.exp
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/support/httpd.exp,v
> >   retrieving revision 1.30
> >   retrieving revision 1.31
> >   diff -u -r1.30 -r1.31
> >   --- httpd.exp 2000/03/13 21:00:41 1.30
> >   +++ httpd.exp 2000/08/30 20:47:37 1.31
> >   @@ -74,6 +74,7 @@
> >    ap_clear_pool
> >    ap_clear_table
> >    ap_close_piped_log
> >   +ap_configtestonly
> >    ap_construct_server
> >    ap_construct_url
> >    ap_content_type_tolower
> >   
> 
> --
> Eric
> 

-- 
Greg Stein, http://www.lyra.org/

Re: cvs commit: apache-1.3/src/support httpd.exp

Posted by Eric Cholet <ch...@logilune.com>.
I'm not sure I follow here, I asked for this weeks ago, it was rejected
and I was advised to submit a patch that passes this variable through
cmd_parms instead of a global. I submitted the patch, but nothing happened.
Are you now back in favor of a global variable for this? It'd be nice
for us to know whether we can include this in the next version of mod_perl.

Thank you

> stoddard    00/08/30 13:47:37
> 
>   Modified:    src/support httpd.exp
>   Log:
>   Export ap_configtestonly. Needed for mod_perl on AIX.
>   
>   Submitted By: Paul Reder
>   
>   Revision  Changes    Path
>   1.31      +1 -0      apache-1.3/src/support/httpd.exp
>   
>   Index: httpd.exp
>   ===================================================================
>   RCS file: /home/cvs/apache-1.3/src/support/httpd.exp,v
>   retrieving revision 1.30
>   retrieving revision 1.31
>   diff -u -r1.30 -r1.31
>   --- httpd.exp 2000/03/13 21:00:41 1.30
>   +++ httpd.exp 2000/08/30 20:47:37 1.31
>   @@ -74,6 +74,7 @@
>    ap_clear_pool
>    ap_clear_table
>    ap_close_piped_log
>   +ap_configtestonly
>    ap_construct_server
>    ap_construct_url
>    ap_content_type_tolower
>   

--
Eric