You are viewing a plain text version of this content. The canonical link for it is here.
Posted to kandula-dev@ws.apache.org by "Bruce G Stewart (JIRA)" <ji...@apache.org> on 2010/03/01 19:17:05 UTC

[jira] Created: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
------------------------------------------------------------------------------

                 Key: AXIS2-4642
                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
             Project: Axis2
          Issue Type: Bug
          Components: kernel
    Affects Versions: 1.5.1
         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
            Reporter: Bruce G Stewart
            Priority: Minor


AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859972#action_12859972 ] 

Andreas Veithen commented on AXIS2-4642:
----------------------------------------

I agree. However, we should complete the Javadoc of those methods so that they specify that it is the responsibility of the caller to close the stream. We should also check that these methods are not invoked by code (e.g. in java2wsdl) that implicitly relies on the fact that the stream is automatically closed. 

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859972#action_12859972 ] 

Andreas Veithen commented on AXIS2-4642:
----------------------------------------

I agree. However, we should complete the Javadoc of those methods so that they specify that it is the responsibility of the caller to close the stream. We should also check that these methods are not invoked by code (e.g. in java2wsdl) that implicitly relies on the fact that the stream is automatically closed. 

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Bruce G Stewart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce G Stewart updated AXIS2-4642:
-----------------------------------

    Description: 
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

[edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]


  was:
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.


> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642-with-javadoc.txt

Hi Andreas,

Here I've re-attached the patch by adding the suggested java doc comments. Also I've indeed earlier checked the usages of the methods I've changed to see if they are affected in any way. And as I found, there weren't any requirement to close the streams, the usages were mainly in a context where a servlet response object was used, where in that case, we anyway should not close the stream, and other places already had "flush" and "close" operations after the methods in question was called, which is actually what we are avoiding with this fix, to not to have close -> flush -> close situations.

Regards,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860217#action_12860217 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

U're welcome :) ..

Thanks,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642.txt

Hi,

Hereby I'm attaching a patch to fix the issue.

A small description and the rationale for the changes,

I've made changes in "ListingAgent" and "AxisService" classes. In the AxisService class, methods which takes in "OutputStream" instances close the streams before they are returned, which is incorrect. As a general rule of thumb, you should not be closing streaming that you did not create. Because the one who's passing the output stream may have operations left to do with it. where in this case, the OutputStream is the servlet's response. Which we should let the servlet container to close, and we can just do "flush" operations to be sure that the data is written immediately. And in my opinion the flush operations also only need to be done in the method that is actually doing the writing, i.e. "getWSDL" in AxisService class.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Bruce G Stewart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce G Stewart updated AXIS2-4642:
-----------------------------------

    Description: 
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

[edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]


  was:
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.


> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved AXIS2-4642.
-------------------------------------------------

    Resolution: Fixed

applied the patch with revision 937237. Thanks Anjana for contribution.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859808#action_12859808 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

Hi,

I'm working on this.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642.txt

Hi,

Hereby I'm attaching a patch to fix the issue.

A small description and the rationale for the changes,

I've made changes in "ListingAgent" and "AxisService" classes. In the AxisService class, methods which takes in "OutputStream" instances close the streams before they are returned, which is incorrect. As a general rule of thumb, you should not be closing streaming that you did not create. Because the one who's passing the output stream may have operations left to do with it. where in this case, the OutputStream is the servlet's response. Which we should let the servlet container to close, and we can just do "flush" operations to be sure that the data is written immediately. And in my opinion the flush operations also only need to be done in the method that is actually doing the writing, i.e. "getWSDL" in AxisService class.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860217#action_12860217 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

U're welcome :) ..

Thanks,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642-with-javadoc.txt

Hi Andreas,

Here I've re-attached the patch by adding the suggested java doc comments. Also I've indeed earlier checked the usages of the methods I've changed to see if they are affected in any way. And as I found, there weren't any requirement to close the streams, the usages were mainly in a context where a servlet response object was used, where in that case, we anyway should not close the stream, and other places already had "flush" and "close" operations after the methods in question was called, which is actually what we are avoiding with this fix, to not to have close -> flush -> close situations.

Regards,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859808#action_12859808 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

Hi,

I'm working on this.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859808#action_12859808 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

Hi,

I'm working on this.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved AXIS2-4642.
-------------------------------------------------

    Resolution: Fixed

applied the patch with revision 937237. Thanks Anjana for contribution.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642.txt

Hi,

Hereby I'm attaching a patch to fix the issue.

A small description and the rationale for the changes,

I've made changes in "ListingAgent" and "AxisService" classes. In the AxisService class, methods which takes in "OutputStream" instances close the streams before they are returned, which is incorrect. As a general rule of thumb, you should not be closing streaming that you did not create. Because the one who's passing the output stream may have operations left to do with it. where in this case, the OutputStream is the servlet's response. Which we should let the servlet container to close, and we can just do "flush" operations to be sure that the data is written immediately. And in my opinion the flush operations also only need to be done in the method that is actually doing the writing, i.e. "getWSDL" in AxisService class.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642-with-javadoc.txt

Hi Andreas,

Here I've re-attached the patch by adding the suggested java doc comments. Also I've indeed earlier checked the usages of the methods I've changed to see if they are affected in any way. And as I found, there weren't any requirement to close the streams, the usages were mainly in a context where a servlet response object was used, where in that case, we anyway should not close the stream, and other places already had "flush" and "close" operations after the methods in question was called, which is actually what we are avoiding with this fix, to not to have close -> flush -> close situations.

Regards,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642.txt

Hi,

Hereby I'm attaching a patch to fix the issue.

A small description and the rationale for the changes,

I've made changes in "ListingAgent" and "AxisService" classes. In the AxisService class, methods which takes in "OutputStream" instances close the streams before they are returned, which is incorrect. As a general rule of thumb, you should not be closing streaming that you did not create. Because the one who's passing the output stream may have operations left to do with it. where in this case, the OutputStream is the servlet's response. Which we should let the servlet container to close, and we can just do "flush" operations to be sure that the data is written immediately. And in my opinion the flush operations also only need to be done in the method that is actually doing the writing, i.e. "getWSDL" in AxisService class.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859808#action_12859808 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

Hi,

I'm working on this.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Bruce G Stewart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce G Stewart updated AXIS2-4642:
-----------------------------------

    Description: 
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

[edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]


  was:
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.


> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860217#action_12860217 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

U're welcome :) ..

Thanks,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860217#action_12860217 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

U're welcome :) ..

Thanks,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Bruce G Stewart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce G Stewart updated AXIS2-4642:
-----------------------------------

    Description: 
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

[edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]


  was:
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.


> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved AXIS2-4642.
-------------------------------------------------

    Resolution: Fixed

applied the patch with revision 937237. Thanks Anjana for contribution.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859972#action_12859972 ] 

Andreas Veithen commented on AXIS2-4642:
----------------------------------------

I agree. However, we should complete the Javadoc of those methods so that they specify that it is the responsibility of the caller to close the stream. We should also check that these methods are not invoked by code (e.g. in java2wsdl) that implicitly relies on the fact that the stream is automatically closed. 

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859808#action_12859808 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

Hi,

I'm working on this.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642-with-javadoc.txt

Hi Andreas,

Here I've re-attached the patch by adding the suggested java doc comments. Also I've indeed earlier checked the usages of the methods I've changed to see if they are affected in any way. And as I found, there weren't any requirement to close the streams, the usages were mainly in a context where a servlet response object was used, where in that case, we anyway should not close the stream, and other places already had "flush" and "close" operations after the methods in question was called, which is actually what we are avoiding with this fix, to not to have close -> flush -> close situations.

Regards,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860217#action_12860217 ] 

Anjana Fernando commented on AXIS2-4642:
----------------------------------------

U're welcome :) ..

Thanks,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859972#action_12859972 ] 

Andreas Veithen commented on AXIS2-4642:
----------------------------------------

I agree. However, we should complete the Javadoc of those methods so that they specify that it is the responsibility of the caller to close the stream. We should also check that these methods are not invoked by code (e.g. in java2wsdl) that implicitly relies on the fact that the stream is automatically closed. 

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved AXIS2-4642.
-------------------------------------------------

    Resolution: Fixed

applied the patch with revision 937237. Thanks Anjana for contribution.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Commented: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859972#action_12859972 ] 

Andreas Veithen commented on AXIS2-4642:
----------------------------------------

I agree. However, we should complete the Javadoc of those methods so that they specify that it is the responsibility of the caller to close the stream. We should also check that these methods are not invoked by code (e.g. in java2wsdl) that implicitly relies on the fact that the stream is automatically closed. 

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Bruce G Stewart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce G Stewart updated AXIS2-4642:
-----------------------------------

    Description: 
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.

[edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]


  was:
AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 

The second close() interferes with the next request on the intermediate ajp connector socket.

I don't know whether calling close() twice should be harmless but, in this case, it is not.


> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642-with-javadoc.txt

Hi Andreas,

Here I've re-attached the patch by adding the suggested java doc comments. Also I've indeed earlier checked the usages of the methods I've changed to see if they are affected in any way. And as I found, there weren't any requirement to close the streams, the usages were mainly in a context where a servlet response object was used, where in that case, we anyway should not close the stream, and other places already had "flush" and "close" operations after the methods in question was called, which is actually what we are avoiding with this fix, to not to have close -> flush -> close situations.

Regards,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Updated: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Anjana Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anjana Fernando updated AXIS2-4642:
-----------------------------------

    Attachment: Axis2Patch-4642.txt

Hi,

Hereby I'm attaching a patch to fix the issue.

A small description and the rationale for the changes,

I've made changes in "ListingAgent" and "AxisService" classes. In the AxisService class, methods which takes in "OutputStream" instances close the streams before they are returned, which is incorrect. As a general rule of thumb, you should not be closing streaming that you did not create. Because the one who's passing the output stream may have operations left to do with it. where in this case, the OutputStream is the servlet's response. Which we should let the servlet container to close, and we can just do "flush" operations to be sure that the data is written immediately. And in my opinion the flush operations also only need to be done in the method that is actually doing the writing, i.e. "getWSDL" in AxisService class.

Cheers,
Anjana.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] Resolved: (AXIS2-4642) ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved AXIS2-4642.
-------------------------------------------------

    Resolution: Fixed

applied the patch with revision 937237. Thanks Anjana for contribution.

> ?wsdl query calls out.close() twice, confusing at least some Tomcat connectors
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2-4642
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4642
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: Axis2.war deployed in Tomcat 6.0.24, using ajp to jk isapi_redirect to IIS on Windows Server 2008.
>            Reporter: Bruce G Stewart
>            Priority: Minor
>         Attachments: Axis2Patch-4642-with-javadoc.txt, Axis2Patch-4642.txt
>
>
> AxisService.getWSDL()  sends the response body for a ..service?wsdl query, then calls .flush() and .close() for its output stream. Upon return, ListingAgent.processListService() calls .flush() and .close() again for the same stream. 
> The second close() interferes with the next request on the intermediate ajp connector socket.
> I don't know whether calling close() twice should be harmless but, in this case, it is not.
> [edit: Actually, the 2nd close() is harmelss. It's the flush() coming after the 1st close() that seems to be the problem.]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org