You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2010/07/09 18:05:49 UTC
[jira] Created: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
SequenceFile and MapFile need cleanup to remove redundant constructors
----------------------------------------------------------------------
Key: HADOOP-6856
URL: https://issues.apache.org/jira/browse/HADOOP-6856
Project: Hadoop Common
Issue Type: Improvement
Components: io
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Fix For: 0.22.0
Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6856:
----------------------------------
Attachment: h-6856.patch
This patch adds the new constructors and makes all of the old (now deprecated) constructors call the new one.
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923843#action_12923843 ]
Hudson commented on HADOOP-6856:
--------------------------------
Integrated in Hadoop-Common-trunk #489 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/])
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886959#action_12886959 ]
Hadoop QA commented on HADOOP-6856:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449138/h-6856.patch
against trunk revision 962677.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
-1 javac. The applied patch generated 1065 javac compiler warnings (more than the trunk's current 1017 warnings).
-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/85/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/85/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/85/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/85/console
This message is automatically generated.
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6856:
----------------------------------
Status: Open (was: Patch Available)
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917826#action_12917826 ]
Konstantin Boudnik commented on HADOOP-6856:
--------------------------------------------
I wonder if all tests were executed in the light of this HADOOP-6989?
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887010#action_12887010 ]
Hadoop QA commented on HADOOP-6856:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449147/h-6856.patch
against trunk revision 962677.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
-1 javac. The applied patch generated 1035 javac compiler warnings (more than the trunk's current 1017 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/86/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/86/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/86/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/86/console
This message is automatically generated.
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-6856:
----------------------------------
Status: Open (was: Patch Available)
+1 I really like the {{Option}} pattern, here. It would be interesting to see it applied in {{FileContext}}
HADOOP-6885 fixed the javadoc warnings; could you regenerate?
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923590#action_12923590 ]
Hudson commented on HADOOP-6856:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #395 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/])
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6856:
----------------------------------
Attachment: h-6856.patch
Fixed the javac and javadoc warnings.
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6856) SequenceFile and MapFile need
cleanup to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley resolved HADOOP-6856.
-----------------------------------
Hadoop Flags: [Reviewed]
Resolution: Fixed
I just committed this.
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6856:
----------------------------------
Status: Patch Available (was: Open)
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch, h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6856) SequenceFile and MapFile need cleanup
to remove redundant constructors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6856:
----------------------------------
Status: Patch Available (was: Open)
> SequenceFile and MapFile need cleanup to remove redundant constructors
> ----------------------------------------------------------------------
>
> Key: HADOOP-6856
> URL: https://issues.apache.org/jira/browse/HADOOP-6856
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: h-6856.patch
>
>
> Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.
> All of this makes it *very* difficult to add new optional parameters to SequenceFile and MapFile.
> I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.