[GitHub] [jena] afs commented on a diff in pull request #1865: Jena issue 1279

["afs (via GitHub)" <gi...@apache.org>]

afs commented on code in PR #1865:
URL: https://github.com/apache/jena/pull/1865#discussion_r1200786303


##########
jena-arq/src/main/java/org/apache/jena/query/ResultSet.java:
##########
@@ -53,6 +54,9 @@ public static ResultSet adapt(RowSet rowSet) {
     @Override
     public QuerySolution next() ;
 
+    @Override

Review Comment:
   If there is an abstract method, then implementations don't get the `java.util.iterator` default implementation for `forEachRemaining`. Was this intended?



##########
jena-benchmarks/jena-benchmarks-jmh/src/test/java/org/apache/jena/JenaVersion.java:
##########


Review Comment:
   Not sure why this is showing as being derived from TestWrappedSetTripleBunch.
   
   Would `JenaVersion` be better in jena-core/main?



##########
jena-tdb1/src/main/java/org/apache/jena/tdb/sys/DatasetControlMRSW.java:
##########
@@ -126,6 +127,13 @@ public T next() {
             }
         }
 
+        @Override
+        public void forEachRemaining(Consumer<? super T> action) {
+            iter.forEachRemaining(action);
+            close();
+            checkIterConcurrentModification();

Review Comment:
   Should this be at the start of the method?



##########
jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java:
##########
@@ -460,6 +475,14 @@ public T next() {
             return t;
         }
 
+        @Override
+        public void forEachRemaining(Consumer<? super T> action) {
+            stream.forEachRemaining(item->{
+                this.action.accept(item);

Review Comment:
   Two calls to action?



##########
jena-arq/src/main/java/org/apache/jena/riot/protobuf/ProtobufRDF.java:
##########


Review Comment:
   Need to remove the now unused import of org.apache.jena.sparql.engine.binding.Binding;



##########
jena-benchmarks/pom.xml:
##########
@@ -0,0 +1,55 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.jena</groupId>
+    <artifactId>jena</artifactId>
+    <version>4.9.0-SNAPSHOT</version>
+    <relativePath>..</relativePath>
+  </parent>
+
+  <name>Apache Jena - Benchmark Suite</name>
+  <artifactId>jena-benchmarks</artifactId>
+  <version>4.9.0-SNAPSHOT</version>
+  <packaging>pom</packaging>
+
+  <description>Suite with different benchmarks.
+  </description>
+
+  <url>https://jena.apache.org/</url>
+
+  <organization>
+    <name>Apache Jena</name>
+    <url>https://jena.apache.org/</url>
+  </organization>
+
+  <licenses>
+    <license>
+      <name>Apache 2.0 License</name>
+      <url>https://www.apache.org/licenses/LICENSE-2.0</url>
+    </license>
+  </licenses>
+
+  <modules>
+    <module>jena-benchmarks-jmh</module>

Review Comment:
   I'm having an IDE build problem.
   
   Code in `TestGraph...` classes depends on a package rooted at `shadedJena480`
   
   e.g.
   ```
   private List<org.apache.shadedJena480.graph.Triple> triples480;
   ```
   which Eclipse isn't finding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org