You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-commits@maven.apache.org by mp...@apache.org on 2006/02/23 16:53:19 UTC

svn commit: r380145 - /maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java

Author: mperham
Date: Thu Feb 23 07:53:16 2006
New Revision: 380145

URL: http://svn.apache.org/viewcvs?rev=380145&view=rev
Log:
PR: SCM-164
Submitted by: John Didion
Fix NPE in Update command

Modified:
    maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java

Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java
URL: http://svn.apache.org/viewcvs/maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java?rev=380145&r1=380144&r2=380145&view=diff
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java Thu Feb 23 07:53:16 2006
@@ -62,6 +62,8 @@
 
     protected ChangeLogCommand getChangeLogCommand()
     {
-        return new PerforceChangeLogCommand();
+        PerforceChangeLogCommand command = new PerforceChangeLogCommand();
+        command.setLogger( getLogger() );
+        return command;
     }
 }

Re: svn commit: r380145 - /maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java

Posted by Emmanuel Venisse <em...@venisse.net>.
I'm not sure this patch is necessary, i patched AbstractUpdateCommand for that i think (need to check)

Emmanuel

mperham@apache.org a écrit :
> Author: mperham
> Date: Thu Feb 23 07:53:16 2006
> New Revision: 380145
> 
> URL: http://svn.apache.org/viewcvs?rev=380145&view=rev
> Log:
> PR: SCM-164
> Submitted by: John Didion
> Fix NPE in Update command
> 
> Modified:
>     maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java
> 
> Modified: maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java
> URL: http://svn.apache.org/viewcvs/maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java?rev=380145&r1=380144&r2=380145&view=diff
> ==============================================================================
> --- maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java (original)
> +++ maven/scm/trunk/maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/update/PerforceUpdateCommand.java Thu Feb 23 07:53:16 2006
> @@ -62,6 +62,8 @@
>  
>      protected ChangeLogCommand getChangeLogCommand()
>      {
> -        return new PerforceChangeLogCommand();
> +        PerforceChangeLogCommand command = new PerforceChangeLogCommand();
> +        command.setLogger( getLogger() );
> +        return command;
>      }
>  }
> 
> 
> 
> 
>