You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/06 09:05:49 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1796: Use IPC row count info in IPC reader

tustvold commented on code in PR #1796:
URL: https://github.com/apache/arrow-rs/pull/1796#discussion_r889960328


##########
arrow/src/ipc/reader.rs:
##########
@@ -608,6 +608,11 @@ pub fn read_record_batch(
     let mut node_index = 0;
     let mut arrays = vec![];
 
+    let options = RecordBatchOptions {
+        match_field_names: true,
+        row_count: Some(batch.length() as usize),
+    };

Review Comment:
   ```suggestion
       let options = RecordBatchOptions {
           row_count: Some(batch.length() as usize),
           ..Default::default()
       };
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org