You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/22 05:50:04 UTC

[GitHub] [skywalking] whfjam opened a new issue #5366: the nodeType about ServiceMeta

whfjam opened a new issue #5366:
URL: https://github.com/apache/skywalking/issues/5366


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [*] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   in the class "org.apache.skywalking.oap.server.core.source.ServiceMeta" why create entity id with
   
   --------------------------------------------
   @Override
       public String getEntityId() {
           return IDManager.ServiceID.buildId(name, NodeType.Normal);
       }
   --------------------------------------------
   if the ServiceMeta is pointed to MQ or others
   
   i think it might be "return IDManager.ServiceID.buildId(name, nodeType);"
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5366: the nodeType about ServiceMeta

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5366:
URL: https://github.com/apache/skywalking/issues/5366


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5366: the nodeType about ServiceMeta

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5366:
URL: https://github.com/apache/skywalking/issues/5366#issuecomment-678618257


   Because that is the point of `ServiceMeta`. All real service IDs are built in this way. What is the question?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5366: the nodeType about ServiceMeta

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5366:
URL: https://github.com/apache/skywalking/issues/5366#issuecomment-678618301


   Normal in the ID means it has the agent, others mean conjecture node.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org