[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8226: Handle int64 columns with missing data in SQL Lab

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #8226: Handle int64 columns with missing data in SQL Lab
URL: https://github.com/apache/incubator-superset/pull/8226#discussion_r324444695
 
 

 ##########
 File path: superset/dataframe.py
 ##########
 @@ -183,7 +205,7 @@ def agg_func(cls, dtype, column_name):
         if (
             hasattr(dtype, "type")
             and issubclass(dtype.type, np.generic)
-            and np.issubdtype(dtype, np.number)
+            and dtype._is_numeric
 
 Review comment:
   Actually, this method is Pandas specific. I'll have to use this and the previous one together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org