[GitHub] grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

[GitBox <gi...@apache.org>]

grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported
URL: https://github.com/apache/qpid-cpp/pull/20#discussion_r246104594
 
 

 ##########
 File path: src/qpid/broker/amqp/Incoming.cpp
 ##########
 @@ -108,7 +109,11 @@ namespace {
 }
 
 DecodingIncoming::DecodingIncoming(pn_link_t* link, Broker& broker, Session& parent, const std::string& source, const std::string& target, const std::string& name)
-    : Incoming(link, broker, parent, source, target, name), sessionPtr(parent.shared_from_this()) {}
 
 Review comment:
   Might be nicer to set in initialiser for consistency (could then also make the attribute a const)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org