You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/25 17:23:05 UTC

[GitHub] [skywalking] dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare

dmsolr commented on issue #3717: fix deficient code, "/socket.io/" http segment declare
URL: https://github.com/apache/skywalking/pull/3717#issuecomment-546439739
 
 
   > @dmsolr , you can have a look
   
   Hi @mrproliu 
   I am sorry to let you know that PR passed because the  Agent-Plugin-Test framework has a bug. Which will be fixed by #3716 .  BTW, you losing some segments in the `expectData.yml` yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services