You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/03/31 09:12:17 UTC
[PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
LuciferYang opened a new pull request, #50463:
URL: https://github.com/apache/spark/pull/50463
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][CONNECT][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2022230622
##########
project/SparkBuild.scala:
##########
@@ -860,10 +850,10 @@ object SparkConnectClient {
(assembly / assemblyShadeRules) := Seq(
ShadeRule.rename("io.grpc.**" -> "org.sparkproject.connect.client.io.grpc.@1").inAll,
- ShadeRule.rename("com.google.**" -> "org.sparkproject.connect.client.com.google.@1").inAll,
+ ShadeRule.rename("com.google.**" -> "org.sparkproject.com.google.@1").inAll,
ShadeRule.rename("io.netty.**" -> "org.sparkproject.connect.client.io.netty.@1").inAll,
ShadeRule.rename("org.checkerframework.**" -> "org.sparkproject.connect.client.org.checkerframework.@1").inAll,
- ShadeRule.rename("javax.annotation.**" -> "org.sparkproject.connect.client.javax.annotation.@1").inAll,
+ // ShadeRule.rename("javax.annotation.**" -> "org.sparkproject.connect.client.javax.annotation.@1").inAll,
Review Comment:
seems we can only delete this `ShadeRule.rename`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020726525
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
What concerns me is this part. I feel like it might bring extra trouble to sbt.
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
What concerns me is this part. I feel like it might bring extra trouble to sbt build and test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020713470
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
Here, we need to rely on the shaded code, and I'm not sure if there will be any obstacles when running tests with sbt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2021181736
##########
project/SparkBuild.scala:
##########
@@ -860,10 +850,10 @@ object SparkConnectClient {
(assembly / assemblyShadeRules) := Seq(
ShadeRule.rename("io.grpc.**" -> "org.sparkproject.connect.client.io.grpc.@1").inAll,
- ShadeRule.rename("com.google.**" -> "org.sparkproject.connect.client.com.google.@1").inAll,
+ ShadeRule.rename("com.google.**" -> "org.sparkproject.com.google.@1").inAll,
ShadeRule.rename("io.netty.**" -> "org.sparkproject.connect.client.io.netty.@1").inAll,
ShadeRule.rename("org.checkerframework.**" -> "org.sparkproject.connect.client.org.checkerframework.@1").inAll,
- ShadeRule.rename("javax.annotation.**" -> "org.sparkproject.connect.client.javax.annotation.@1").inAll,
+ // ShadeRule.rename("javax.annotation.**" -> "org.sparkproject.connect.client.javax.annotation.@1").inAll,
Review Comment:
for fix:
```
[warn] javac exited with exit code 1
[error] (connect-client-integration-tests / Test / compileIncremental) javac returned non-zero exit code
```
will take another look at it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020725429
##########
sql/connect/client/jvm/pom.xml:
##########
@@ -175,21 +175,27 @@
<include>com.google.common.**</include>
</includes>
</relocation>
+ <relocation>
Review Comment:
Here, I've made the relocation rules for pb consistent with those on the server side, otherwise errors would occur during compilation and testing. Let me think about if there's a better way to handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][CONNECT][TESTS] Migrate the tests related to `RemoteSparkSession` from the `connect-client-jvm` module to `connect-client-integration-tests` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2022667425
##########
.github/workflows/maven_test.yml:
##########
@@ -198,7 +198,7 @@ jobs:
if [[ "$INCLUDED_TAGS" != "" ]]; then
./build/mvn $MAVEN_CLI_OPTS -pl "$TEST_MODULES" -Pyarn -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pjvm-profiler -Pspark-ganglia-lgpl -Pkinesis-asl -Djava.version=${JAVA_VERSION/-ea} -Dtest.include.tags="$INCLUDED_TAGS" test -fae
elif [[ "$MODULES_TO_TEST" == "connect" ]]; then
- ./build/mvn $MAVEN_CLI_OPTS -Dtest.exclude.tags="$EXCLUDED_TAGS" -Djava.version=${JAVA_VERSION/-ea} -pl sql/connect/client/jvm,sql/connect/common,sql/connect/server test -fae
+ ./build/mvn $MAVEN_CLI_OPTS -Dtest.exclude.tags="$EXCLUDED_TAGS" -Djava.version=${JAVA_VERSION/-ea} -pl sql/connect/client/jvm,sql/connect/client/integration-tests,sql/connect/common,sql/connect/server package test -fae
Review Comment:
Here, it is necessary to use `package test`. If only `test` is specified, then `client-integration-tests` will use the `client-jvm`'s classes directory instead of a jar file as the build classpath, which will result in a failure of `testCompile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][CONNECT][TESTS] Migrate the tests related to `RemoteSparkSession` from the `connect-client-jvm` module to `connect-client-integration-tests` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50463:
URL: https://github.com/apache/spark/pull/50463#issuecomment-3059696845
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020860520
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2021185137
##########
project/SparkBuild.scala:
##########
@@ -860,10 +850,10 @@ object SparkConnectClient {
(assembly / assemblyShadeRules) := Seq(
ShadeRule.rename("io.grpc.**" -> "org.sparkproject.connect.client.io.grpc.@1").inAll,
- ShadeRule.rename("com.google.**" -> "org.sparkproject.connect.client.com.google.@1").inAll,
+ ShadeRule.rename("com.google.**" -> "org.sparkproject.com.google.@1").inAll,
Review Comment:
needs to be consistent with Maven; otherwise, the compilation of `UDFClassLoadingE2ESuite` will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][CONNECT][TESTS] Migrate the tests related to `RemoteSparkSession` from the `connect-client-jvm` module to `connect-client-integration-tests` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #50463:
URL: https://github.com/apache/spark/pull/50463#issuecomment-2769453832
cc @HyukjinKwon This pr is basically completed, and we can discuss its feasibility. There might still be some duplicate code that can be cleaned up, but I think we can leave that for a follow-up if this plan is feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #50463:
URL: https://github.com/apache/spark/pull/50463#issuecomment-2765719365
cc @HyukjinKwon I'm trying to do this refactoring. Do you have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2021179069
##########
project/SparkBuild.scala:
##########
@@ -878,6 +868,37 @@ object SparkConnectClient {
)
}
+object SparkConnectClientIT {
Review Comment:
locally run `build/sbt "connect-client-integration-tests/test" -Phive`，all test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][CONNECT][TESTS] Migrate the tests related to `RemoteSparkSession` from the `connect-client-jvm` module to `connect-client-integration-tests` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50463: [SPARK-51653][CONNECT][TESTS] Migrate the tests related to `RemoteSparkSession` from the `connect-client-jvm` module to `connect-client-integration-tests`
URL: https://github.com/apache/spark/pull/50463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #50463:
URL: https://github.com/apache/spark/pull/50463#issuecomment-2765688760
Step 1: Move the test cases related to RemoteSparkSession to the `spark-connect-client-integration-tests` module and ensure that the Maven tests run successfully.
TODO:
2. Ensure that the tests run successfully with sbt.
3. Make other related modifications and perform code cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51653][TESTS] Migrate the tests related to RemoteSparkSession from the connect-client-jvm module to a standalone module. [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020708353
##########
assembly/pom.xml:
##########
@@ -150,6 +154,7 @@
<build>
<plugins>
+ <!--
Review Comment:
need to install and deploy the assembly module, otherwise dependencies cannot be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org