You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2017/04/22 13:45:19 UTC

[text] revert b0027e18d2e634e2a822962f6fbd3d296c82e722 "StrTokenizer#clone: add super.clone() call to fix findbug warning"

Repository: commons-text
Updated Branches:
  refs/heads/master b0027e18d -> 0b8532b5b


revert b0027e18d2e634e2a822962f6fbd3d296c82e722 "StrTokenizer#clone: add super.clone() call to fix findbug warning"

use findbug version from commons-parent

use fb-excludes when findbugs is run outside the site lifecyle


Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/0b8532b5
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/0b8532b5
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/0b8532b5

Branch: refs/heads/master
Commit: 0b8532b5bfcf8aedd303c2c0e97296a50d48fa1b
Parents: b0027e1
Author: Pascal Schumacher <pa...@gmx.net>
Authored: Sat Apr 22 15:45:12 2017 +0200
Committer: Pascal Schumacher <pa...@gmx.net>
Committed: Sat Apr 22 15:45:12 2017 +0200

----------------------------------------------------------------------
 pom.xml                                               | 14 +++++++++++---
 .../java/org/apache/commons/text/StrTokenizer.java    |  1 -
 2 files changed, 11 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-text/blob/0b8532b5/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index c4d8e2c..eade4ce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -176,6 +176,15 @@
         </configuration>
       </plugin>
       <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+        <!-- Use version from parent pom as that is adjusted according to the Java version used to run Maven -->
+        <version>${commons.findbugs.version}</version>
+        <configuration>
+          <excludeFilterFile>${basedir}/fb-excludes.xml</excludeFilterFile>
+        </configuration>
+      </plugin>
+      <plugin>
         <artifactId>maven-assembly-plugin</artifactId>
         <configuration>
           <descriptors>
@@ -233,10 +242,9 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <version>3.0.0</version>
+        <!-- Use version from parent pom as that is adjusted according to the Java version used to run Maven -->
+        <version>${commons.findbugs.version}</version>
         <configuration>
-          <threshold>Normal</threshold>
-          <effort>Default</effort>
           <excludeFilterFile>${basedir}/fb-excludes.xml</excludeFilterFile>
         </configuration>
       </plugin>

http://git-wip-us.apache.org/repos/asf/commons-text/blob/0b8532b5/src/main/java/org/apache/commons/text/StrTokenizer.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/StrTokenizer.java b/src/main/java/org/apache/commons/text/StrTokenizer.java
index b539268..66126ec 100644
--- a/src/main/java/org/apache/commons/text/StrTokenizer.java
+++ b/src/main/java/org/apache/commons/text/StrTokenizer.java
@@ -1088,7 +1088,6 @@ public class StrTokenizer implements ListIterator<String>, Cloneable {
     @Override
     public Object clone() {
         try {
-            super.clone();
             return cloneReset();
         } catch (final CloneNotSupportedException ex) {
             return null;