[GitHub] [arrow] stopyransky commented on pull request #11701: ARROW-14711: [Javascript] Fixed TextDecoder for old NodeJS versions

[GitBox <gi...@apache.org>]

stopyransky commented on pull request #11701:
URL: https://github.com/apache/arrow/pull/11701#issuecomment-986935175


   > I'm not very familiar with the node APIs but it seems like this change will break in browsers.
   
   Since this PR is the answer for issue #11662 (Node environment issue) the browser environment will not see the change as `require` check, used to determine if global object should be augmented, is undefined in the browser.
   Additional/alternative check could be `typeof window === 'undefined'` to ensure this will not break into browser env.
   
   However I think both solutions will not be helpful as the issue is found in test environment (when running unit tests react-testing-library) and this test environment contains both window object and require function so the global object is not augmented - issue persists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org