You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/09/01 19:44:52 UTC
[Impala-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks
Hello Internal Jenkins, Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4222
to review the following change.
Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
......................................................................
IMPALA-3946: fix MemPool integrity issues with empty chunks
There were various rare code paths that results in the MemPool failing
its own internal integrity checks. This required various small fixes to
ensure that the MemPool was always valid even when there were empty
chunks for various reasons (either from calling Clear() or
ReturnPartialAllocation()).
Testing:
Added unit tests for three secenarios where the integrity check failed.
Also ran fuzz tester to confirm that the original issue was fixed.
Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Reviewed-on: http://gerrit.cloudera.org:8080/3838
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 88b89b872dbab6b13df2adbbb40704da96f987ac)
---
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-pool.h
3 files changed, 145 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/22/4222/1
--
To view, visit http://gerrit.cloudera.org:8080/4222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change.
Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I03ad12e5b2b63cbb55e5c52562416d73a4bd9346
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>