You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rtudoran <gi...@git.apache.org> on 2017/05/28 12:15:25 UTC
[GitHub] flink pull request #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/4003
[FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huawei-flink/flink FLINK-6075-OFRe3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4003.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4003
----
commit 52acb914b8fbdb2f36d6b2f732cc161b97fa6f2c
Author: didi <di...@batcave-desktop>
Date: 2017-05-28T12:13:41Z
Add full support for Order By with Fetch and Offset
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske
I have implemented meanwhile also the support for offset and fetch for both rowtime and proctime. This PR includes all the modifications and reviews you made for #3889.
You can either go ahead first with that one and chekc if the basis is ok and merge that - and then we move to this one, or we can consider this directly. This PR will close the JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@shijinkui @hongyuhong @stefanobortoli
I add you to the issue to track the progress
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/4003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4003
Thanks for the update @rtudoran.
I'm traveling for another week before I return in the office. I hope I'll find time to have a look at #3889 in the next days. I think we should try to get that in first and later rebase this PR once the first part has been merged.
Thank you, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske - Fine for me! I just wanted to finish this as well :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
I have updated these contributions against the master branch and based on the latest modifications after the merge of the basis for orderby. I opened a new PR for this #4263.
I will close this one as it is not relevant anymore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4003: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Posted by rtudoran <gi...@git.apache.org>.
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske I will re-factor these contributions (hopefully by the end of the week) based on the things that are already merged from order by. I will ping you soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---