You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 13:51:32 UTC

[GitHub] [airflow] ashb opened a new pull request #9346: Mark task as failed when it fails in Celery

ashb opened a new pull request #9346:
URL: https://github.com/apache/airflow/pull/9346


   If a task failed _hard_ on celery, the task would end up stuck in queued state. This change makes it get retried.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #9346: Mark task as failed when it fails in Celery

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9346:
URL: https://github.com/apache/airflow/pull/9346#issuecomment-645386794


   I'm double checking how to reproduce this -- I think it was if it failed before being able to update the task status in the DB this task would be wedged until a scheduler restart.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] stale[bot] commented on pull request #9346: Mark task as failed when it fails in Celery

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9346:
URL: https://github.com/apache/airflow/pull/9346#issuecomment-670836638


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] stale[bot] closed pull request #9346: Mark task as failed when it fails in Celery

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9346:
URL: https://github.com/apache/airflow/pull/9346


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #9346: Mark task as failed when it fails in Celery

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9346:
URL: https://github.com/apache/airflow/pull/9346#issuecomment-645408112


   @kaxil Any thoughts on how best to test this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org