You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "burmecia (via GitHub)" <gi...@apache.org> on 2023/06/01 07:43:50 UTC

[GitHub] [arrow-rs] burmecia opened a new pull request, #4331: fix: make SerializedRowGroupReader::new() public

burmecia opened a new pull request, #4331:
URL: https://github.com/apache/arrow-rs/pull/4331

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4330.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   `SerializedRowGroupReader::new()` must be public, otherwise it cannot be created outside.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Add `pub` for `SerializedRowGroupReader::new()` function to make it public.
   
   # Are there any user-facing changes?
   
   Nope
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4331: Make SerializedRowGroupReader::new() public

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4331:
URL: https://github.com/apache/arrow-rs/pull/4331#issuecomment-1573189357

   The file in SerializedFileReader refers to a parquet file, as opposed to a file on disk. You can pass in Bytes as the input


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4331: Make SerializedRowGroupReader::new() public

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4331:
URL: https://github.com/apache/arrow-rs/pull/4331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4331: fix: make SerializedRowGroupReader::new() public

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4331:
URL: https://github.com/apache/arrow-rs/pull/4331#issuecomment-1571721002

   It is intended that users make use of https://docs.rs/parquet/latest/parquet/file/serialized_reader/struct.SerializedFileReader.html#method.get_row_group to instantiate this, is there a particular reason this doesn't work for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] burmecia commented on pull request #4331: Make SerializedRowGroupReader::new() public

Posted by "burmecia (via GitHub)" <gi...@apache.org>.
burmecia commented on PR #4331:
URL: https://github.com/apache/arrow-rs/pull/4331#issuecomment-1573179231

   Thanks for that link. My case is the parquet is only in memory, such as http response, so there is no file can open, so I just want to find a way directly the rows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org