You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/31 04:37:10 UTC
[PR] fix(amber): preserve evaluated values [texera]
carloea2 opened a new pull request, #8236:
URL: https://github.com/apache/texera/pull/8236
### What is this PR for?
Add the worker's `EvaluatedValue` reply to the generic `ControlReturn` transport. This prevents evaluated Python expression results from being replaced by an empty return before they reach the coordinator.
Closes #8235
### What type of PR is it?
Bug Fix
### How was this PR tested?
```text
python -c "import sys,pytest; sys.path[:0]=[worktree amber source]; raise SystemExit(pytest.main(['amber/src/test/python/core/architecture/rpc/test_async_rpc_handler_initializer.py','amber/src/test/python/core/architecture/rpc/test_async_rpc_server.py','amber/src/test/python/core/architecture/handlers/control/test_evaluate_expression_handler.py','-q','-p','no:cacheprovider']))"
81 passed
ruff check amber/src/main/python amber/src/test/python
All checks passed
ruff format --check amber/src/main/python amber/src/test/python
213 files already formatted
```
The Python protobuf bindings were regenerated from the changed descriptor for verification and remain ignored as required by the repository. A direct post-fix transport probe produced:
```text
packed_type=EvaluatedValue
packed_value=42
round_trip=True
```
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5473830133
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 4 worse · ⚪ 9 noise (<±5%) · 0 without baseline
> Compared against main `50321e4` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33357736659)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 417 | 0.254 | 23,078/31,267/31,267 us | 🔴 -7.3% / 🔴 +111.4% |
| 🔴 | bs=100 sw=10 sl=64 | 925 | 0.564 | 105,725/141,863/141,863 us | 🔴 +7.3% / 🔴 +40.5% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,095 | 0.668 | 917,049/991,231/991,231 us | ⚪ within ±5% / ⚪ within ±5% |
<details><summary>Baseline details</summary>
Latest main `50321e4` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 417 tuples/sec | 449 tuples/sec | 844.57 tuples/sec | -7.1% | -50.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.254 MB/s | 0.274 MB/s | 0.515 MB/s | -7.3% | -50.7% |
| bs=10 sw=10 sl=64 | p50 | 23,078 us | 21,870 us | 11,837 us | +5.5% | +95.0% |
| bs=10 sw=10 sl=64 | p95 | 31,267 us | 33,400 us | 14,788 us | -6.4% | +111.4% |
| bs=10 sw=10 sl=64 | p99 | 31,267 us | 33,400 us | 17,651 us | -6.4% | +77.1% |
| bs=100 sw=10 sl=64 | throughput | 925 tuples/sec | 929 tuples/sec | 1,084 tuples/sec | -0.4% | -14.7% |
| bs=100 sw=10 sl=64 | MB/s | 0.564 MB/s | 0.567 MB/s | 0.662 MB/s | -0.5% | -14.8% |
| bs=100 sw=10 sl=64 | p50 | 105,725 us | 98,571 us | 94,505 us | +7.3% | +11.9% |
| bs=100 sw=10 sl=64 | p95 | 141,863 us | 143,693 us | 100,941 us | -1.3% | +40.5% |
| bs=100 sw=10 sl=64 | p99 | 141,863 us | 143,693 us | 108,642 us | -1.3% | +30.6% |
| bs=1000 sw=10 sl=64 | throughput | 1,095 tuples/sec | 1,110 tuples/sec | 1,119 tuples/sec | -1.4% | -2.2% |
| bs=1000 sw=10 sl=64 | MB/s | 0.668 MB/s | 0.678 MB/s | 0.683 MB/s | -1.5% | -2.2% |
| bs=1000 sw=10 sl=64 | p50 | 917,049 us | 890,679 us | 924,404 us | +3.0% | -0.8% |
| bs=1000 sw=10 sl=64 | p95 | 991,231 us | 994,242 us | 967,785 us | -0.3% | +2.4% |
| bs=1000 sw=10 sl=64 | p99 | 991,231 us | 994,242 us | 995,630 us | -0.3% | -0.4% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,480.18,200,128000,417,0.254,23077.74,31266.96,31266.96
1,100,10,64,20,2162.98,2000,1280000,925,0.564,105724.92,141862.87,141862.87
2,1000,10,64,20,18270.89,20000,12800000,1095,0.668,917049.14,991231.05,991231.05
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5473788829
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Yicong-Huang`, `@eugenegujing`
You can notify them by mentioning `@Yicong-Huang`, `@eugenegujing` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5483393627
Amber failed in TexeraWebSocketEventSpec after the ActorSystem shutdown error. PyAmber and both Amber integration jobs passed. I cannot rerun repository jobs as a contributor. Could someone rerun Amber?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 closed pull request #8236: fix(amber): preserve evaluated values
URL: https://github.com/apache/texera/pull/8236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5473788444
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/protobuf/org/apache/texera/amber/engine/architecture/rpc/controlreturns.proto`, `amber/src/test/python/core/architecture/rpc/test_async_rpc_handler_initializer.py`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33357724257)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5650068878
Thanks for the fix. I'm closing this PR as a duplicate of #7927.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5473863374
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 95.51%. Comparing base ([`50321e4`](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`03e6028`](https://app.codecov.io/gh/apache/texera/commit/03e6028377f772076abe5cf264b487d92b6f13b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8236 +/- ##
============================================
+ Coverage 93.93% 95.51% +1.58%
+ Complexity 4761 2863 -1898
============================================
Files 1191 929 -262
Lines 48308 39797 -8511
Branches 5377 4220 -1157
============================================
- Hits 45378 38014 -7364
+ Misses 1495 961 -534
+ Partials 1435 822 -613
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `93.35% <ø> (+3.33%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.41% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <ø> (ø)` | | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8236/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8236?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5483882954
I am converting this PR to a draft: please follow our PR template and mark it ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5484010340
The description now follows the current template, and this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(amber): preserve evaluated values [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8236:
URL: https://github.com/apache/texera/pull/8236#issuecomment-5473788156
<!-- texera:template-compliance -->
👋 Thanks for opening this pull request, @carloea2!
It looks like the pull request description doesn't quite follow our template yet:
- The **What changes were proposed in this PR?** section is missing; please keep the template's headings.
- The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org