You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jean-Baptiste Quenot <jb...@apache.org> on 2007/04/11 11:04:05 UTC
Re: Recent changes in Session factory method
* jonl@apache.org:
> Author: jonl
> Date: Tue Apr 10 17:34:21 2007
> New Revision: 527352
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=527352
> Log:
> Changed WebSession/Session constructor so that RequestCycle is available earlier. This is necessary when doing session factories that need access to the response through the request cycle threadlocal (to set cookies on the user during unit testing, for example).
* jcompagner@apache.org:
> Author: jcompagner
> Date: Wed Apr 11 00:56:29 2007
> New Revision: 527406
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=527406
> Log:
> rollback of the create of the RequestCycle in the session constructor (need to find another way if this is needed)
I don't understand what's going on in the Wicket world! Where and
when did we agree to change the arguments of newSession()? It
seems very amateurish to me how this change could be checked in
with such a miserable lack of communication.
Wicket 1.3 is *not* a sandbox. Everyone has its own sandbox, this
is where the experimental stuff needs to go. I love people
experimenting new stuff, myself included, but we must *not* walk
into each other's shoes and break the API without prior consent of
the other developers. There are people spending their volunteer
time to catchup will all the changes that occured in the last
weeks, but don't abuse of them.
Or maybe I am missing something? Tell me that my mail server
filtered out the important messages, or tell me that I'm having a
bad dream.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Recent changes in Session factory method
Posted by Matej Knopp <ma...@gmail.com>.
I think you are overreacting. Wicket 1.x is still a development
release. We don't guarantee api stability. And I don't think this was
a major change.
-Matej
On 4/11/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> * jonl@apache.org:
> > Author: jonl
> > Date: Tue Apr 10 17:34:21 2007
> > New Revision: 527352
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=527352
> > Log:
> > Changed WebSession/Session constructor so that RequestCycle is available earlier. This is necessary when doing session factories that need access to the response through the request cycle threadlocal (to set cookies on the user during unit testing, for example).
>
> * jcompagner@apache.org:
> > Author: jcompagner
> > Date: Wed Apr 11 00:56:29 2007
> > New Revision: 527406
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=527406
> > Log:
> > rollback of the create of the RequestCycle in the session constructor (need to find another way if this is needed)
>
> I don't understand what's going on in the Wicket world! Where and
> when did we agree to change the arguments of newSession()? It
> seems very amateurish to me how this change could be checked in
> with such a miserable lack of communication.
>
> Wicket 1.3 is *not* a sandbox. Everyone has its own sandbox, this
> is where the experimental stuff needs to go. I love people
> experimenting new stuff, myself included, but we must *not* walk
> into each other's shoes and break the API without prior consent of
> the other developers. There are people spending their volunteer
> time to catchup will all the changes that occured in the last
> weeks, but don't abuse of them.
>
> Or maybe I am missing something? Tell me that my mail server
> filtered out the important messages, or tell me that I'm having a
> bad dream.
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>