You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lovepoem (GitHub)" <gi...@apache.org> on 2019/01/05 14:45:13 UTC

[GitHub] [incubator-dubbo] lovepoem opened pull request #3149: Upgrade junt to junit5

## What is the purpose of the change
https://github.com/apache/incubator-dubbo/issues/3148
Upgrade junt to junit5

## Brief changelog
1. Upgrade junt to junit5
2. Batch modification of test cases

## Verifying this change

CI success 

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> will this change impact test coverage?
@htynkn   May be it is  because the pr 
https://github.com/apache/incubator-dubbo/pull/3116  I create before using the same branch , so this pr didn't appear the test coverage diff. 

The diff appeaded in the https://github.com/apache/incubator-dubbo/pull/3116 is 0 , so it looks will not impact

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3149: Upgrade junt to junit5

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=h1) Report
> Merging [#3149](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/460c3a17568ff31f994646558a48c2d0e7b37bd4?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3149      +/-   ##
============================================
+ Coverage     63.59%   63.64%   +0.04%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28200    28200              
  Branches       4781     4781              
============================================
+ Hits          17935    17948      +13     
+ Misses         8013     7991      -22     
- Partials       2252     2261       +9
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `70.73% <0%> (-14.64%)` | `0% <0%> (ø)` | |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `78.12% <0%> (-6.25%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `70.49% <0%> (-4.92%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/remoting/transport/AbstractCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDb2RlYy5qYXZh) | `76.92% <0%> (-3.85%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | `0% <0%> (ø)` | |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `82.75% <0%> (-3.45%)` | `0% <0%> (ø)` | |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `55.81% <0%> (-2.33%)` | `0% <0%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=footer). Last update [460c3a1...b147ac5](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> the file you copied has different copy right head, does that one need exclude from plugin check？

Yes , I found it and fixed 
Another question : are the  sopied source files  needed to be filed in the LICENSE file ?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> the file you copied has different copy right head, does that one need exclude from plugin check？

Yes , I found it and fixed 
Another question : are the  sopied source files  needed be filed in the LICENSE file ?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3149: Upgrade junt to junit5

Posted by "htynkn (GitHub)" <gi...@apache.org>.
looks good to me. by the way, the file you copied has different copy right head, does that one need exclude from plugin check？

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3149: Upgrade junt to junit5

Posted by "htynkn (GitHub)" <gi...@apache.org>.
@lovepoem hey I fix this test coverage issue and create a pr to your repo
https://github.com/lovepoem/dubbo/pull/1

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on issue #3149: Upgrade junt to junit5

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
LGTM, merged.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> the file you copied has different copy right head, does that one need exclude from plugin check？

Yes , I found it and fixed 
Another question : are the  copied source files  needed to be filed in the LICENSE ?  @ralf0131 @beiwei30 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3149: Upgrade junt to junit5

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=h1) Report
> Merging [#3149](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/460c3a17568ff31f994646558a48c2d0e7b37bd4?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3149      +/-   ##
============================================
+ Coverage     63.55%   63.64%   +0.08%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28200    28200              
  Branches       4781     4781              
============================================
+ Hits          17922    17947      +25     
+ Misses         8023     7993      -30     
- Partials       2255     2260       +5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-8.2%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/remoting/transport/AbstractCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDb2RlYy5qYXZh) | `76.92% <0%> (-3.85%)` | `0% <0%> (ø)` | |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `55.81% <0%> (-2.33%)` | `0% <0%> (ø)` | |
| [...mmon/serialize/kryo/utils/AbstractKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by91dGlscy9BYnN0cmFjdEtyeW9GYWN0b3J5LmphdmE=) | `78.57% <0%> (-1.79%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `71.81% <0%> (-1.35%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/redis/RedisProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL3JlZGlzL1JlZGlzUHJvdG9jb2wuamF2YQ==) | `59.75% <0%> (-1.22%)` | `0% <0%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=footer). Last update [460c3a1...da2a528](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
This pr use junit-jupiter [5.4.0-M1](https://github.com/junit-team/junit5/releases/tag/r5.4.0-M1) and junit-platform  for some test cases.

Should Wait for the 5.4.0 release version

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
As @htynkn  suggested, I copied some 5.4.0-m1 code in https://github.com/apache/incubator-dubbo/pull/3149/commits/4e06253078b291321792cdce5902f2ed935412d5 .  Because some cases need some features of junit-jupiter 5.4.0

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3149: Upgrade junt to junit5

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=h1) Report
> Merging [#3149](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/460c3a17568ff31f994646558a48c2d0e7b37bd4?src=pr&el=desc) will **decrease** coverage by `63.55%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master   #3149       +/-   ##
============================================
- Coverage     63.55%      0%   -63.56%     
============================================
  Files           652     652               
  Lines         28200   28200               
  Branches       4781    4781               
============================================
- Hits          17922       0    -17922     
- Misses         8023   28200    +20177     
+ Partials       2255       0     -2255
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/status/Status.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL1N0YXR1cy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/http/servlet/ServletManager.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvaHR0cC9zZXJ2bGV0L1NlcnZsZXRNYW5hZ2VyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...p/exchange/support/MulticastExchangeNetworker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZU5ldHdvcmtlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...va/com/alibaba/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/support/threadlocal/ThreadLocalCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...igurator/override/OverrideConfiguratorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL292ZXJyaWRlL092ZXJyaWRlQ29uZmlndXJhdG9yRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [546 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=footer). Last update [460c3a1...8c8cf4a](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> will this change impact test coverage?

@htynkn   Maybe it is  because the pr 
https://github.com/apache/incubator-dubbo/pull/3116  I create before using the same branch , so this pr didn't appear the test coverage diff. 

The diff appeaded in the https://github.com/apache/incubator-dubbo/pull/3116 is 0 , so it looks will not impact

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
>    org.junit.jupiter.api.support.io.TempDirectory.java
org.junit.jupiter.api.MethodDescriptor
org.junit.jupiter.api.TestMethodOrder
org.junit.jupiter.api.Order
org.junit.jupiter.api.MethodOrderer
org.junit.jupiter.api.MethodOrdererContext
org.junit.jupiter.api.MethodDescriptor
The file list is copid from jupiter 5.4.0.M1  , the license is `Eclipse Public License - v 2.0`

The files are removed 




[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.


```java
org.junit.jupiter.api.support.io.TempDirectory.java
org.junit.jupiter.api.MethodDescriptor
org.junit.jupiter.api.TestMethodOrder
org.junit.jupiter.api.Order
org.junit.jupiter.api.MethodOrderer
org.junit.jupiter.api.MethodOrdererContext
org.junit.jupiter.api.MethodDescriptor
```
The file list is copid from jupiter 5.4.0.M1  , the license is `Eclipse Public License - v 2.0`


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3149: Upgrade junt to junit5

Posted by "htynkn (GitHub)" <gi...@apache.org>.
will this change impact test coverage?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3149: Upgrade junt to junit5

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=h1) Report
> Merging [#3149](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2cbc83f144d0346c440ffd5b88933c941a6a792c?src=pr&el=desc) will **decrease** coverage by `63.55%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master   #3149       +/-   ##
============================================
- Coverage     63.55%      0%   -63.56%     
============================================
  Files           652     652               
  Lines         28200   28200               
  Branches       4782    4782               
============================================
- Hits          17922       0    -17922     
- Misses         8026   28200    +20174     
+ Partials       2252       0     -2252
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/status/Status.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL1N0YXR1cy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/http/servlet/ServletManager.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvaHR0cC9zZXJ2bGV0L1NlcnZsZXRNYW5hZ2VyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...p/exchange/support/MulticastExchangeNetworker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZU5ldHdvcmtlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...va/com/alibaba/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/support/threadlocal/ThreadLocalCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...igurator/override/OverrideConfiguratorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL292ZXJyaWRlL092ZXJyaWRlQ29uZmlndXJhdG9yRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [546 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=footer). Last update [2cbc83f...21e8e7b](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
As @htynkn  suggested, I copied some 5.4.0-m1 code in https://github.com/apache/incubator-dubbo/pull/3149/commits/4e06253078b291321792cdce5902f2ed935412d5 .  Because some cases need some features of junit-jupiter 5.4.0. Now the version is 5.3.2

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3149: Upgrade junt to junit5

Posted by "htynkn (GitHub)" <gi...@apache.org>.
@lovepoem hey I fix this issue and create a pr to your repo
https://github.com/lovepoem/dubbo/pull/1

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> hey I fix this test coverage issue and create a pr to your repo
lovepoem#1

@htynkn , the test coverage is normal now,  thank you very much 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> will this change impact test coverage?

@htynkn   May be it is  because the pr 
https://github.com/apache/incubator-dubbo/pull/3116  I create before using the same branch , so this pr didn't appear the test coverage diff. 

The diff appeaded in the https://github.com/apache/incubator-dubbo/pull/3116 is 0 , so it looks will not impact

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3149: Upgrade junt to junit5

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
> the file you copied has different copy right head, does that one need exclude from plugin check？
Yes , I found it and fixed 
Are sopied source files  needed be filed in the LICENSE file ?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #3149: Upgrade junt to junit5

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3149: Upgrade junt to junit5

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=h1) Report
> Merging [#3149](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2cbc83f144d0346c440ffd5b88933c941a6a792c?src=pr&el=desc) will **decrease** coverage by `63.55%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master   #3149       +/-   ##
============================================
- Coverage     63.55%      0%   -63.56%     
============================================
  Files           652     652               
  Lines         28200   28200               
  Branches       4782    4782               
============================================
- Hits          17922       0    -17922     
- Misses         8026   28200    +20174     
+ Partials       2252       0     -2252
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/status/Status.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL1N0YXR1cy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/http/servlet/ServletManager.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvaHR0cC9zZXJ2bGV0L1NlcnZsZXRNYW5hZ2VyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...p/exchange/support/MulticastExchangeNetworker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZU5ldHdvcmtlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...va/com/alibaba/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/support/threadlocal/ThreadLocalCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...igurator/override/OverrideConfiguratorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL292ZXJyaWRlL092ZXJyaWRlQ29uZmlndXJhdG9yRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [546 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3149/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=footer). Last update [2cbc83f...21e8e7b](https://codecov.io/gh/apache/incubator-dubbo/pull/3149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3149 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org