[jira] [Commented] (YUNIKORN-1124) Avoid passing empty nodeAttributes in UpdateNode request

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507915#comment-17507915 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1124:
-------------------------------------------------

The cases that we pass in an empty list of attributes is when we delete, re-instate or decommission a node. For those cases we really do not need any attributes. We just need to know the node for which we need to change the status.

This is all linked to the fact that the shim does not set a node partition. We have YUNIKORN-802 open for this. Support for setting the partition to anything is not in the shim. That is why all nodes end up in the default partition. The core must have a partition, if it is missing the _default_ partition is set. The setting of the partition to the default is the root cause of YUNIKORN-1123.

For the real update we never pass an empty list as we have at least a status to send.

We *MUST* handle missing attributes in the message correctly on the core side. So we should initialise the map, if the map is nil, to set the partition.

> Avoid passing empty nodeAttributes in UpdateNode request
> --------------------------------------------------------
>
>                 Key: YUNIKORN-1124
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1124
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>            Reporter: Manikandan R
>            Assignee: Manikandan R
>            Priority: Major
>             Fix For: 1.0.0
>
>
> YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in UpdateNode request. But it is better to handle this empty checks in core itself and avoid passing empty attributes map from shim side. In addition, need to assess the following:
>  
>  # Does core uses OccupiedResource and labels attributes being sent as part of Create NodeRequest from shim?
>  # By any chance, Does shim need to pass yunikorn.apache.org/nodeType attribute to core? Anyway, need to make it as constant



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org